Attachment 166133 Details for Bug 27753 – Bug 27753: (follow-up) Tidy unit tests

[patch] Bug 27753: (follow-up) Tidy unit tests

Bug-27753-follow-up-Tidy-unit-tests.patch (text/plain), 3.12 KB, created by Martin Renvoize (ashimema) on 2024-05-03 14:16:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-03 14:16:48 UTC

Size: 3.12 KB

patch

obsolete

>From afbd9762241cd83566a31d9e8e38acc6fc63543e Mon Sep 17 00:00:00 2001
>From: Laura Escamilla <laura.escamilla@bywatersolutions.com>
>Date: Tue, 30 Apr 2024 15:56:41 +0000
>Subject: [PATCH] Bug 27753: (follow-up) Tidy unit tests
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Circulation.t | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 67dec5509e7..16616d19091 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -2636,30 +2636,30 @@ subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
> subtest "Bug 27753 - Add AutoClaimReturnStatusOnCheckin" => sub {
>     plan tests => 8;
>     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
>-    t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
>-    t::lib::Mocks::mock_preference( 'ClaimReturnedLostValue', 1 );
>+    t::lib::Mocks::mock_userenv( { branchcode => $library2->{branchcode} } );
>+    t::lib::Mocks::mock_preference( 'ClaimReturnedLostValue',         1 );
>     t::lib::Mocks::mock_preference( 'AutoClaimReturnStatusOnCheckin', 1 );
>-    my $item = $builder->build_sample_item ({library=>$library2->{branchcode}});
>+    my $item     = $builder->build_sample_item( { library => $library2->{branchcode} } );
>     my $patron   = $builder->build_object( { class => 'Koha::Patrons' } );
>     my $checkout = AddIssue( $patron, $item->barcode );
> 
>     my $claim = $checkout->claim_returned(
>-            {
>-              created_by => $patron->id,
>-              notes      => "Test note",
>-            }
>-        );
>-    is( $claim->issue_id, $checkout->id, "Claim issue id matches" );
>-    is( $claim->itemnumber, $item->id, "Claim itemnumber matches" );
>-    is( $claim->borrowernumber, $patron->id, "Claim borrowernumber matches" );
>-    is( $claim->notes, "Test note", "Claim notes match" );
>-    is( $claim->created_by, $patron->id, "Claim created_by matches" );
>+        {
>+            created_by => $patron->id,
>+            notes      => "Test note",
>+        }
>+    );
>+    is( $claim->issue_id,       $checkout->id, "Claim issue id matches" );
>+    is( $claim->itemnumber,     $item->id,     "Claim itemnumber matches" );
>+    is( $claim->borrowernumber, $patron->id,   "Claim borrowernumber matches" );
>+    is( $claim->notes,          "Test note",   "Claim notes match" );
>+    is( $claim->created_by,     $patron->id,   "Claim created_by matches" );
>     ok( $claim->created_on, "Claim created_on is set" );
> 
>-    my ( $doreturn, $messages) = AddReturn ( $item->barcode, $library->{branchcode} );
>-    is (ref $messages->{ClaimAutoResolved}, 'Koha::Checkouts::ReturnClaim', "Claim auto resolved upon checkin");
>+    my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->{branchcode} );
>+    is( ref $messages->{ClaimAutoResolved}, 'Koha::Checkouts::ReturnClaim', "Claim auto resolved upon checkin" );
>     $claim->discard_changes;
>-    ok( $claim->resolved_by, "Claim is resolved");
>+    ok( $claim->resolved_by, "Claim is resolved" );
> };
> 
> subtest 'MultipleReserves' => sub {
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 27753: 162517 | 163058 | 163059 | 163060 | 163061 | 163084 | 163085 | 163090 | 163469 | 163470 | 163474 | 163475 | 163476 | 163477 | 163479 | 163480 | 165911 | 165912 | 165914 | 165915 | 165916 | 165917 | 165918 | 165919 | 165920 | 165952 | 165953 | 165958 | 165959 | 166128 | 166129 | 166130 | 166131 | 166132 | 166133 | 166134 | 166135 | 166136 | 166137