Attachment 166137 Details for Bug 27753 – Bug 27753: (QA follow-up) Use librarian as resolver

[patch] Bug 27753: (QA follow-up) Use librarian as resolver

Bug-27753-QA-follow-up-Use-librarian-as-resolver.patch (text/plain), 1.62 KB, created by Martin Renvoize (ashimema) on 2024-05-03 14:17:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-03 14:17:02 UTC

Size: 1.62 KB

patch

obsolete

>From b9f57befeed7312bf2deada32b070d26f851fc3b Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 1 May 2024 12:58:17 +0100
>Subject: [PATCH] Bug 27753: (QA follow-up) Use librarian as resolver
>
>This patch updates the changed code to set the logged in librarian as
>the person who resolved the return claim at checkin/checkout action.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Circulation.pm   | 2 +-
> circ/circulation.pl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 2e24b990759..bff0b1e2f56 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2546,7 +2546,7 @@ sub AddReturn {
>             my $autoClaimReturnCheckin = C4::Context->preference('AutoClaimReturnStatusOnCheckin');
>             if ($autoClaimReturnCheckin) {
> 
>-                my $patron_id  = $patron->borrowernumber;
>+                my $patron_id  = C4::Context->userenv ? C4::Context->userenv->{'number'} : undef;
>                 my $resolution = $autoClaimReturnCheckin;
> 
>                 $claim->resolve(
>diff --git a/circ/circulation.pl b/circ/circulation.pl
>index 81e0f337aec..d1c2b3b0cfb 100755
>--- a/circ/circulation.pl
>+++ b/circ/circulation.pl
>@@ -450,7 +450,7 @@ if (@$barcodes && $op eq 'cud-checkout') {
>             if ($autoClaimReturnCheckout) {
>                 my $claim = $claims->next;
> 
>-                my $patron_id  = $patron->borrowernumber;
>+                my $patron_id  = $logged_in_user->borrowernumber;
>                 my $resolution = $autoClaimReturnCheckout;
> 
>                 $claim->resolve(
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 27753: 162517 | 163058 | 163059 | 163060 | 163061 | 163084 | 163085 | 163090 | 163469 | 163470 | 163474 | 163475 | 163476 | 163477 | 163479 | 163480 | 165911 | 165912 | 165914 | 165915 | 165916 | 165917 | 165918 | 165919 | 165920 | 165952 | 165953 | 165958 | 165959 | 166128 | 166129 | 166130 | 166131 | 166132 | 166133 | 166134 | 166135 | 166136 | 166137