Attachment 166154 Details for Bug 36534 – Bug 36534: Batch operations when using limit in report

[patch] Bug 36534: Batch operations when using limit in report

Bug-36534-Batch-operations-when-using-limit-in-rep.patch (text/plain), 2.50 KB, created by Owen Leonard on 2024-05-03 17:25:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-05-03 17:25:44 UTC

Size: 2.50 KB

patch

obsolete

>From f4eda70a8ab4058e5d72aa57617d64752d6859e8 Mon Sep 17 00:00:00 2001
>From: Katariina Pohto <trainee@koha-suomi.fi>
>Date: Thu, 2 May 2024 14:27:06 +0300
>Subject: [PATCH] Bug 36534: Batch operations when using limit in report
>
>When report results number exceeds the result per page limit, batch
>operations link reads "Batch operations with (page limit) records" even
>if there are more or less shown records (more when using limit in SQL or
>less in the last page of result). This patch fixes the link text to
>actual shown records.
>
>To test:
>1) Create a report of items with a limit of e.g., 26.
>2) Run report.
>3) See that number of results shown exceeds 20 but the link says "Batch
>   operations with 20 visible records".
>4) See that the second page shows 6 results but the link is still for 20
>   records.
>5) Apply patch.
>6) Run report again.
>7) See that the link texts will show correctly 26 records on the first
>   page and 6 records on the second.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/modules/reports/guided_reports_start.tt             | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 3b0da777a8..50f7a65a4f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1055,7 +1055,7 @@
>                                         [% IF ( batch_biblionumbers || batch_itemnumbers || batch_cardnumbers || batch_borrowernumbers ) %]
>                                             <div class="btn-group">
>                                                 <button class="btn btn-default btn-sm dropdown-toggle" type="button" id="batch_mod_menu" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true">
>-                                                    Batch operations with [% IF unlimited_total >= limit %][% limit | html %][% ELSE %][% unlimited_total | html %][% END %] visible records
>+                                                    Batch operations with [% IF unlimited_total >= limit %][% results.size | html %][% ELSE %][% unlimited_total | html %][% END %] visible records
>                                                     <span class="caret"></span>
>                                                 </button>
>                                                 <ul class="dropdown-menu" aria-labelledby="batch_mod_menu">
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36534: 166068 | 166154 | 166403