Bugzilla – Attachment 166162 Details for
Bug 36774
Flatpickr clear() adds unintentional clear button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36774: [DONT PUSH] TEST ONLY
Bug-36774-DONT-PUSH-TEST-ONLY.patch (text/plain), 1.47 KB, created by
David Nind
on 2024-05-04 20:32:39 UTC
(
hide
)
Description:
Bug 36774: [DONT PUSH] TEST ONLY
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-05-04 20:32:39 UTC
Size:
1.47 KB
patch
obsolete
>From dd1b011c6f163eb730e8d5567bd1d81521236a96 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 3 May 2024 14:14:42 +0000 >Subject: [PATCH] Bug 36774: [DONT PUSH] TEST ONLY > >Test plan: >1) Apply only the TEST patch >2) Visit http://localhost:8081/cgi-bin/koha/serials/serials-home.pl >3) Click the "Expires before" input and insert any date >4) Click the "TEST" link under. It calls the native flatpickr.clear(): > https://flatpickr.js.org/instance-methods-properties-elements/#clear >5) Notice it clears the date value. But it also appends a new 'x' icon to clear the input. >6) Apply 2nd patch. Repeat. Notice it works as expected > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../intranet-tmpl/prog/en/modules/serials/serials-home.tt | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt >index 22e8960ea7..872f07637d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt >@@ -56,6 +56,10 @@ > [% Asset.js("js/serials-toolbar.js") | $raw %] > <script> > var subscriptionid = "[% subscriptionid | html %]"; >+ >+ $('.rows').append('<a href="#" id="36774">TEST</a>'); >+ $("#36774").on( "click", function() { $("#to").flatpickr().clear(); } ); >+ > </script> > [% END %] > [% INCLUDE 'intranet-bottom.inc' %] >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36774
:
166138
|
166139
|
166162
|
166163
|
166278
|
166303
|
166304
|
166305
|
166383
|
166384
|
166385
|
166395
|
166396
|
166423
|
166424
|
166425
|
166427
|
166463
|
166464