Bugzilla – Attachment 166208 Details for
Bug 29948
Display author information for researchers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29948: Fix display of selected values
Bug-29948-Fix-display-of-selected-values.patch (text/plain), 1.49 KB, created by
David Nind
on 2024-05-06 11:09:04 UTC
(
hide
)
Description:
Bug 29948: Fix display of selected values
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-05-06 11:09:04 UTC
Size:
1.49 KB
patch
obsolete
>From 8b6f4bbe1126b3a6d0a588a794decbc17ef64b08 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 22 Mar 2024 12:46:21 +0100 >Subject: [PATCH] Bug 29948: Fix display of selected values > >The values were correctly inserted but the display was not sorting >correctly > >Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es> >Signed-off-by: David Nind <david@davidnind.com> >--- > admin/preferences.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/admin/preferences.pl b/admin/preferences.pl >index 66f7208998..6c2bd49c62 100755 >--- a/admin/preferences.pl >+++ b/admin/preferences.pl >@@ -32,7 +32,7 @@ use Koha::Database::Columns; > use IO::File; > use YAML::XS; > use Encode; >-use List::MoreUtils qw( any ); >+use List::MoreUtils qw( any uniq ); > > sub GetTab { > my ( $input, $tab ) = @_; >@@ -165,8 +165,8 @@ sub _get_chunk { > my @values; > @values = split /,/, $value if defined($value); > $chunk->{type} = 'multiple_sortable'; >+ my @options = sort keys %{ $options{multiple_sortable} }; > $chunk->{CHOICES} = [ >- sort { $a->{'text'} cmp $b->{'text'} } > map { > my $option_value = $_; > { >@@ -175,7 +175,7 @@ sub _get_chunk { > selected => (grep { $_ eq $option_value } @values) ? 1 : 0, > } > } >- keys %{ $options{multiple_sortable} } >+ uniq(@values, @options) > ]; > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29948
:
163167
|
163168
|
163169
|
163696
|
163697
|
163698
|
163699
|
163700
|
166166
|
166167
|
166168
|
166169
|
166181
|
166183
|
166184
|
166185
|
166186
|
166197
|
166198
|
166199
|
166200
|
166201
|
166202
|
166203
|
166205
|
166206
|
166207
|
166208
|
166209
|
166210
|
166211
|
166594
|
166595
|
166596
|
166597
|
166598
|
166599
|
166600
|
166642