Bugzilla – Attachment 166273 Details for
Bug 30579
When placing item level hold, some options that are not used are not disabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30579: (follow-up) Fix rebase of multi holds form and add CSRF
Bug-30579-follow-up-Fix-rebase-of-multi-holds-form.patch (text/plain), 4.96 KB, created by
Nick Clemens (kidclamp)
on 2024-05-07 12:36:32 UTC
(
hide
)
Description:
Bug 30579: (follow-up) Fix rebase of multi holds form and add CSRF
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-05-07 12:36:32 UTC
Size:
4.96 KB
patch
obsolete
>From ecc234405cf3a96f197b624bcf1c2ed1562cf6fc Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 7 May 2024 12:01:33 +0000 >Subject: [PATCH] Bug 30579: (follow-up) Fix rebase of multi holds form and add > CSRF > >This patch restores missing elemtns to multi-hold form and adds CSRF variables >--- > .../prog/en/modules/reserve/request.tt | 44 ++++++++++++++++++- > 1 file changed, 42 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 6a2a696d799..533e169476e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1049,8 +1049,10 @@ > <fieldset class="rows"> > <legend>Hold details</legend> > <form action="placerequest.pl" method="post" name="form" id="hold-request-form"> >- <input type="hidden" name="multi_holds" id="multi_holds" value="1" /> >- <input type="hidden" name="request" value="any"/> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="op" value="cud-placerequest" /> >+ <input type="hidden" name="multi_holds" id="multi_holds" value="1" /> >+ <input type="hidden" name="request" value="any"/> > <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" /> > [% FOREACH biblioloo IN biblioloop %] > <input type="hidden" name="biblionumber" id="biblionumber" value="[% biblioloo.biblionumber | html %]"/> >@@ -1061,6 +1063,44 @@ > [% END %] > [% END %] > >+ <ol> >+ >+ <li> >+ <span class="label">Patron:</span> >+ [% IF ( patron.borrowernumber ) %] >+ [% INCLUDE 'patron-title.inc' patron => patron no_title => 1 hide_patron_infos_if_needed => 1 %] >+ [% ELSE %] >+ Not defined yet >+ [% END %] >+ </li> >+ >+ >+ <li> >+ <label for="holdnotes">Notes:</label> >+ <textarea id="holdnotes" name="notes" cols="30" rows="1"></textarea> >+ </li> >+ <li> >+ <label for="pickup">Pickup at:</label> >+ <select name="pickup" id="pickup_multi" data-patron-id="[% patron.borrowernumber | html %]"> >+ <option value="" selected="selected"></option> >+ [% FOREACH pickup_location IN multi_pickup_locations %] >+ <option value="[% pickup_location.branchcode | html %]">[% pickup_location.branchname | html %]</option> >+ [% END %] >+ </select> >+ </li> >+ [% IF ( Koha.Preference('AllowHoldDateInFuture') ) %] >+ <li> >+ <label for="from">Hold starts on date:</label> >+ <input id="reserve_date" name="reserve_date" id="from" size="10" type="text" data-date_to="expiration_date" class="flatpickr" data-flatpickr-futureinclusive="true" /> >+ </li> >+ [% END %] >+ >+ <li> >+ <label for="to">Hold expires on date:</label> >+ <input id="expiration_date" name="expiration_date" id="to" size="10" type="text" class="flatpickr" data-flatpickr-futuredate="true" /> >+ </li> >+ >+ </ol> > <table id="requesttitles"> > <tr> > <th> </th> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30579
:
133549
|
133550
|
133574
|
133575
|
133689
|
133690
|
134270
|
134468
|
134469
|
134491
|
134492
|
134493
|
134893
|
134894
|
140951
|
140952
|
140953
|
140954
|
148835
|
148898
|
149271
|
150767
|
150786
|
151483
|
151493
|
151558
|
154881
|
154882
|
154883
|
154886
|
157787
|
157788
|
157789
|
157790
|
157791
|
157792
|
157937
|
157938
|
157939
|
157940
|
157941
|
157942
|
157943
|
163260
|
163261
|
163262
|
163263
|
163264
|
163265
|
163266
|
163267
|
166012
|
166013
|
166014
|
166015
|
166016
|
166017
|
166018
|
166019
|
166034
|
166035
|
166036
|
166037
|
166038
|
166039
|
166040
|
166041
|
166074
|
166075
|
166076
|
166077
|
166078
|
166079
|
166080
|
166081
|
166082
|
166264
|
166265
|
166266
|
166267
|
166268
|
166269
|
166270
|
166271
|
166272
| 166273 |
166274
|
166275