Attachment 166275 Details for Bug 30579 – Bug 30579: (follow-up) Style selections as buttons

[patch] Bug 30579: (follow-up) Style selections as buttons

Bug-30579-follow-up-Style-selections-as-buttons.patch (text/plain), 7.79 KB, created by Nick Clemens (kidclamp) on 2024-05-07 12:36:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-05-07 12:36:39 UTC

Size: 7.79 KB

patch

obsolete

>From 021a1d405e6b8a0e266b1c3e34eba51ba55b7f7f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 7 May 2024 12:35:04 +0000
>Subject: [PATCH] Bug 30579: (follow-up) Style selections as buttons
>
>---
> .../prog/en/modules/reserve/request.tt        | 74 ++++++++++---------
> 1 file changed, 40 insertions(+), 34 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 7f012eba7a7..86b975d799d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -613,18 +613,20 @@
>                             </fieldset>
>                             <fieldset class="rows">
>                                 <legend>
>-                                    <label for="requestany" class="inline">
>-                                        Hold next available item
>-                                    </label>
>-                                    [% IF force_hold_level == 'item' || force_hold_level == 'item_group' %]
>-                                        <input type="radio" id="requestany" name="request" disabled="true" />
>-                                    [% ELSIF force_hold_level == 'record' %]
>-                                        <input type="radio" id="requestany" checked="checked" value="Any" disabled="true"/>
>-                                        <input type="hidden" name="request" value="Any"/>
>-                                        <span class="error"><i>(Required)</i></span>
>-                                    [% ELSE %]
>-                                        <input type="radio" id="requestany" name="request" checked="checked" value="Any" />
>-                                    [% END %]
>+                                    <button type="button">
>+                                        [% IF force_hold_level == 'item' || force_hold_level == 'item_group' %]
>+                                            <input type="radio" id="requestany" name="request" disabled="true" />
>+                                        [% ELSIF force_hold_level == 'record' %]
>+                                            <input type="radio" id="requestany" checked="checked" value="Any" disabled="true"/>
>+                                            <input type="hidden" name="request" value="Any"/>
>+                                            <span class="error"><i>(Required)</i></span>
>+                                        [% ELSE %]
>+                                            <input type="radio" id="requestany" name="request" checked="checked" value="Any" />
>+                                        [% END %]
>+                                        <label for="requestany" class="inline">
>+                                            Hold next available item
>+                                        </label>
>+                                    </button>
>                                 </legend>
>                                 <input type="hidden" name="alreadyreserved" value="[% alreadyreserved | html %]" />
>                                 <fieldset class="enable_request_any disable_request_group disable_request_specific">
>@@ -695,17 +697,19 @@
>                         [% IF Koha.Preference('EnableItemGroupHolds') && biblio_info.object.item_groups.count %]
>                         <fieldset class="rows">
>                             <legend>
>-                                <label for="requestgrp" class="inline">
>-                                    Hold next available item from an item group
>-                                </label>
>-                                [% IF force_hold_level == 'item_group' %]
>-                                    <input type="radio" class="requestgrp" id="requestgrp" name="request" checked="checked" disabled="true" />
>-                                    <span class="error"><i>(Required)</i></span>
>-                                [% ELSIF force_hold_level == 'item' || force_hold_level == 'record' %]
>-                                    <input type="radio" class="requestgrp" id="requestgrp" name="request" disabled="true" />
>-                                [% ELSE %]
>-                                    <input type="radio" class="requestgrp" id="requestgrp" name="request" />
>-                                [% END %]
>+                                <button type="button">
>+                                    [% IF force_hold_level == 'item_group' %]
>+                                        <input type="radio" class="requestgrp" id="requestgrp" name="request" checked="checked" disabled="true" />
>+                                        <span class="error"><i>(Required)</i></span>
>+                                    [% ELSIF force_hold_level == 'item' || force_hold_level == 'record' %]
>+                                        <input type="radio" class="requestgrp" id="requestgrp" name="request" disabled="true" />
>+                                    [% ELSE %]
>+                                        <input type="radio" class="requestgrp" id="requestgrp" name="request" />
>+                                    [% END %]
>+                                    <label for="requestgrp" class="inline">
>+                                        Hold next available item from an item group
>+                                    </label>
>+                                </button>
>                             </legend>
> 
>                             <fieldset class="enable_request_group disable_request_any disable_request_specific">
>@@ -792,17 +796,19 @@
> 
>                         <fieldset class="rows">
>                             <legend>
>-                                <label for="requestspecificitem" class="inline">
>-                                    Hold a specific item
>-                                </label>
>-                                [% IF force_hold_level == 'item' %]
>-                                     <input type="radio" id="requestspecificitem" name="request" class="requestspecific" checked="checked" disabled='disabled'/>
>-                                     <span class="error"><em>(Required)</em></span>
>-                                [% ELSIF force_hold_level == 'record' || force_hold_level == 'item_group' %]
>-                                     <input type="radio" id="requestspecificitem" name="request" class="requestspecific" disabled='disabled'/>
>-                                [% ELSE %]
>-                                     <input type="radio" id="requestspecificitem" name="request" class="requestspecific"/>
>-                                [% END %]
>+                                <button type="button">
>+                                    [% IF force_hold_level == 'item' %]
>+                                         <input type="radio" id="requestspecificitem" name="request" class="requestspecific" checked="checked" disabled='disabled'/>
>+                                         <span class="error"><em>(Required)</em></span>
>+                                    [% ELSIF force_hold_level == 'record' || force_hold_level == 'item_group' %]
>+                                         <input type="radio" id="requestspecificitem" name="request" class="requestspecific" disabled='disabled'/>
>+                                    [% ELSE %]
>+                                         <input type="radio" id="requestspecificitem" name="request" class="requestspecific"/>
>+                                    [% END %]
>+                                    <label for="requestspecificitem" class="inline">
>+                                        Hold a specific item
>+                                    </label>
>+                                </button>
>                             </legend>
> 
>                             <fieldset class="enable_request_specific disable_request_any disable_request_group">
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 30579: 133549 | 133550 | 133574 | 133575 | 133689 | 133690 | 134270 | 134468 | 134469 | 134491 | 134492 | 134493 | 134893 | 134894 | 140951 | 140952 | 140953 | 140954 | 148835 | 148898 | 149271 | 150767 | 150786 | 151483 | 151493 | 151558 | 154881 | 154882 | 154883 | 154886 | 157787 | 157788 | 157789 | 157790 | 157791 | 157792 | 157937 | 157938 | 157939 | 157940 | 157941 | 157942 | 157943 | 163260 | 163261 | 163262 | 163263 | 163264 | 163265 | 163266 | 163267 | 166012 | 166013 | 166014 | 166015 | 166016 | 166017 | 166018 | 166019 | 166034 | 166035 | 166036 | 166037 | 166038 | 166039 | 166040 | 166041 | 166074 | 166075 | 166076 | 166077 | 166078 | 166079 | 166080 | 166081 | 166082 | 166264 | 166265 | 166266 | 166267 | 166268 | 166269 | 166270 | 166271 | 166272 | 166273 | 166274 | 166275