Bugzilla – Attachment 166288 Details for
Bug 36750
OPAC - some facet heading labels are not displayed in search results when using Elasticsearch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36750: (35138 follow-up) Use same display code for OPAC
Bug-36750-35138-follow-up-Use-same-display-code-fo.patch (text/plain), 5.37 KB, created by
Jonathan Druart
on 2024-05-07 14:14:18 UTC
(
hide
)
Description:
Bug 36750: (35138 follow-up) Use same display code for OPAC
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-05-07 14:14:18 UTC
Size:
5.37 KB
patch
obsolete
>From 2b40d5a319f9c8a578a7ee6080e9b83931ed7126 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 2 May 2024 16:44:36 +0000 >Subject: [PATCH] Bug 36750: (35138 follow-up) Use same display code for OPAC > >To test: >1 - In OPAC with ES enabled do a search >2 - Note missing facet labels >3 - Apply patch >4 - They are back! > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/includes/facets.inc | 2 +- > .../bootstrap/en/includes/opac-facets.inc | 55 +++++++++---------- > 2 files changed, 26 insertions(+), 31 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index fa6c6def470..27b34bfeaf5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -64,7 +64,7 @@ > <span id="facet-series">Series</span> > [% CASE 'ItemTypes' %] > <span id="facet-itemtypes">Item types</span> >- [% CASE 'HomeLibrary' %] >+ [% CASE 'homelibrary' %] > <span id="facet-home-libraries">Home libraries</span> > [% CASE 'HoldingLibrary' %] > <span id="facet-holding-libraries">Holding libraries</span> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >index 635058eb820..90aa92f0078 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >@@ -54,37 +54,32 @@ > [% FOREACH facets_loo IN facets_loop %] > [% IF facets_loo.facets.size > 0 %] > <li id="[% facets_loo.type_id | html %]"> >- [% SWITCH facets_loo.label %] >- [% CASE 'Authors' %] >- <h3 id="facet-authors">Authors</h3> >- [% CASE 'Titles' %] >- <h3 id="facet-titles">Titles</h3> >- [% CASE 'Topics' %] >- <h3 id="facet-topics">Topics</h3> >- [% CASE 'Places' %] >- <h3 id="facet-places">Places</h3> >- [% CASE 'Series' %] >- <h3 id="facet-series">Series</h3> >- [% CASE 'ItemTypes' %] >- <h3 id="facet-itemtypes">Item types</h3> >- [% CASE 'Location' %] >- <h3 id="facet-locations">Locations</h3> >- [% CASE 'CollectionCodes' %] >- <h3 id="facet-collections">Collections</h3> >- [% CASE 'Languages' %] >- <h3 id="facet-languages">Languages</h3> >- [% CASE %] >- <h3 id="facet-[% facets_loo.type_link_value | html %]">[% facets_loo.label | html %]</h3> >- [% END %] >- >- [% UNLESS singleBranchMode %] >- [% IF ( facets_loo.label == HomeLibrary ) %] >- <h3 id="facet-home-libraries">Home libraries</h3> >+ [% SWITCH facets_loo.label %] >+ [% CASE 'Authors' %] >+ <h3 id="facet-authors">Authors</h3> >+ [% CASE 'Titles' %] >+ <h3 id="facet-titles">Titles</h3> >+ [% CASE 'Topics' %] >+ <h3 id="facet-topics">Topics</h3> >+ [% CASE 'Places' %] >+ <h3 id="facet-places">Places</h3> >+ [% CASE 'Series' %] >+ <h3 id="facet-series">Series</h3> >+ [% CASE 'ItemTypes' %] >+ <h3 id="facet-itemtypes">Item types</h3> >+ [% CASE 'homelibrary' %] >+ <h3 id="facet-home-libraries">Home libraries</h3> >+ [% CASE 'HoldingLibrary' %] >+ <h3 id="facet-holding-libraries">Holding libraries</h3> >+ [% CASE 'Location' %] >+ <h3 id="facet-locations">Locations</h3> >+ [% CASE 'CollectionCodes' %] >+ <h3 id="facet-collections">Collections</h3> >+ [% CASE 'Languages' %] >+ <h3 id="facet-languages">Languages</h3> >+ [% CASE %] >+ <h3 id="facet-[% facets_loo.type_link_value | html %]">[% facets_loo.label | html %]</h3> > [% END %] >- [% IF ( facets_loo.label == 'HoldingLibrary' ) %] >- <h3 id="facet-holding-libraries">Holding libraries</h3> >- [% END %] >- [% END %] > <ul> > [% SET url = "/cgi-bin/koha/opac-search.pl?" _ query_cgi _ limit_cgi %] > [% IF ( sort_by ) %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36750
:
166031
|
166032
|
166083
|
166084
|
166187
|
166191
|
166192
|
166193
|
166194
|
166281
|
166282
|
166283
|
166284
|
166286
| 166288 |
166289
|
166290
|
166291
|
166292