Attachment 166313 Details for Bug 35648 – Bug 35648: (follow-up) Clear table filter before submitting

[patch] Bug 35648: (follow-up) Clear table filter before submitting

Bug-35648-follow-up-Clear-table-filter-before-subm.patch (text/plain), 1.88 KB, created by Kyle M Hall (khall) on 2024-05-07 16:40:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-05-07 16:40:09 UTC

Size: 1.88 KB

patch

obsolete

>From b66b97856894f428227c6da2373228b2364aec9f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 22 Mar 2024 12:47:22 +0000
>Subject: [PATCH] Bug 35648: (follow-up) Clear table filter before submitting
>
>This patch takes advise from elasticsearch-mappings.js and adds an
>onsubmit event to clear any DataTables filter before submitting. This
>should prevent hidden fields from being overwritten.
>
>To test, filter the table and make a change to one of the visible rows.
>After submitting, confirm that the previously-hidden rows retain the
>same settings as before.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/tools/overduerules.tt   | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
>index 3cfd0939f7c..7b9e57f8624 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
>@@ -67,7 +67,7 @@
>             </div>
>             [% END %]
>             [% IF ( table ) %]
>-                <form method="post" action="/cgi-bin/koha/tools/overduerules.pl">
>+                <form method="post" id="overduerulesf" action="/cgi-bin/koha/tools/overduerules.pl">
>                     [% INCLUDE 'csrf-token.inc' %]
>                     <input type="hidden" name="op" value="cud-save" />
>                     <input type="hidden" name="branch" value="[% branch | html %]" />
>@@ -198,6 +198,12 @@
>                 "dom": '<"top pager"f>rt<"clear">',
>                 "paginate": false,
>             }));
>+
>+            $("#overduerulesf").on("submit", function(e){
>+                $(".overduerulest").DataTable().search('').draw();
>+                return true;
>+            });
>+
>         });
>     </script>
> [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35648: 160455 | 160495 | 160498 | 163702 | 166153 | 166312 | 166313 | 166314