Bugzilla – Attachment 166322 Details for
Bug 32256
Self checkout batch mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32256: (follow-up) Use correct patron category
Bug-32256-follow-up-Use-correct-patron-category.patch (text/plain), 1.97 KB, created by
Martin Renvoize (ashimema)
on 2024-05-07 17:52:53 UTC
(
hide
)
Description:
Bug 32256: (follow-up) Use correct patron category
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-05-07 17:52:53 UTC
Size:
1.97 KB
patch
obsolete
>From 69dd1918bc94a4d439e5a1b2af241e83f5009de2 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 10 Apr 2024 00:58:30 +0000 >Subject: [PATCH] Bug 32256: (follow-up) Use correct patron category > >This patch ensures we check the categorycode of the patron trying to issue the items is valid (based on BatchCheckoutsValidCategories), rather than the categorycode of the AutoSelfCheckAllowed patron. > >To test: > >1 - Enable BatchCheckouts, select nothing in BatchCheckoutsValidCategories >2 - confirm AutoSelfCheckAllowed is allowed and contains the username and password for the self_check user. Confirm self_check user is in category Staff >3 - log into SCO with a user in category Patron, confirm you can only check out 1 item at a time >4 - select Patron in BatchCheckoutsValidCategories >5 - log into SCO with your Patron user again, confirm you can check out multiple items at a time > >Sponsored-by: Koha-US >Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/sco/sco-main.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl >index 55b4355f597..7f4593b71b2 100755 >--- a/opac/sco/sco-main.pl >+++ b/opac/sco/sco-main.pl >@@ -138,9 +138,9 @@ my $branch = $issuer->{branchcode}; > my $confirm_required = 0; > my $return_only = 0; > >-if ( C4::Context->preference('BatchCheckouts') ) { >+if ( C4::Context->preference('BatchCheckouts') and $patron ) { > my @batch_category_codes = split ',', C4::Context->preference('BatchCheckoutsValidCategories'); >- my $categorycode = $issuer->{categorycode}; >+ my $categorycode = $patron->categorycode; > if ( $categorycode && grep { $_ eq $categorycode } @batch_category_codes ) { > # do nothing - logged in patron is allowed to do batch checkouts > } else { >-- >2.45.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32256
:
154866
|
154893
|
158585
|
158586
|
163878
|
163879
|
164571
|
164572
|
164573
|
164637
|
164638
|
164639
|
164640
|
164869
|
165719
|
165751
|
165752
|
165753
|
165754
|
165755
|
165978
|
165979
|
165980
|
165981
|
165982
|
165983
|
166179
|
166225
|
166226
|
166227
|
166228
|
166229
|
166230
|
166231
|
166320
|
166321
| 166322 |
166323
|
166324
|
166325
|
166326