Attachment 166357 Details for Bug 35285 – Bug 35285: Remove switch in notices.tt

[patch] Bug 35285: Remove switch in notices.tt

Bug-35285-Remove-switch-in-noticestt.patch (text/plain), 2.23 KB, created by Martin Renvoize (ashimema) on 2024-05-08 08:27:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-08 08:27:38 UTC

Size: 2.23 KB

patch

obsolete

>From 8469a7b8ee2d222801e4cf2dc65c6882c7a4ccc2 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 8 Nov 2023 10:43:09 +0000
>Subject: [PATCH] Bug 35285: Remove switch in notices.tt
>
>We now wrap appropriately for non-html formatted messages as
>part of the html_content method. This means we can remove the
>case from members/notices.tt and rely on html_content doing
>the right thing for notice previews.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
>index d9e5e569e75..b26bededd20 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
>@@ -1,6 +1,5 @@
> [% USE raw %]
> [% USE Asset %]
>-[% USE String %]
> [% USE Koha %]
> [% USE AuthorisedValues %]
> [% USE Branches %]
>@@ -67,11 +66,7 @@
>                                         <tr>
>                                             <td>
>                                                 <a class="notice-title" data-noticeid="[% QUEUED_MESSAGE.message_id | html %]" href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% borrowernumber | uri %]&amp;noticeid=[% QUEUED_MESSAGE.message_id | uri %]">[% QUEUED_MESSAGE.subject | html %]</a>
>-                                                [% IF QUEUED_MESSAGE.content_type.search('html') %]
>                                                 <iframe class="notice" id="notice[% QUEUED_MESSAGE.message_id | html %]" srcdoc="[% QUEUED_MESSAGE.html_content | html %]"></iframe>
>-                                                [% ELSE %]
>-                                                <iframe class="notice" id="notice[% QUEUED_MESSAGE.message_id | html %]" srcdoc="[% QUEUED_MESSAGE.content | html | html_line_break %]"></iframe>
>-                                                [% END %]
>                                             </td>
>                                             <td>
>                                                 [% IF ( QUEUED_MESSAGE.message_transport_type == 'email' ) %]<span>email</span>
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 35285: 158657 | 158658 | 158889 | 158890 | 158891 | 158960 | 158961 | 158962 | 166329 | 166330 | 166331 | 166332 | 166333 | 166334 | 166348 | 166349 | 166350 | 166356 | 166357 | 166358 | 166719 | 166720 | 166721 | 166722