Bugzilla – Attachment 166396 Details for
Bug 36774
Flatpickr clear() adds unintentional clear button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36774: (QA Follow-up): Use flatpickr clear
Bug-36774-QA-Follow-up-Use-flatpickr-clear.patch (text/plain), 1.29 KB, created by
Jonathan Druart
on 2024-05-08 12:19:18 UTC
(
hide
)
Description:
Bug 36774: (QA Follow-up): Use flatpickr clear
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-05-08 12:19:18 UTC
Size:
1.29 KB
patch
obsolete
>From 38ea4490318b9007fd74353f8e2b12f57b551998 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 7 May 2024 15:45:39 +0000 >Subject: [PATCH] Bug 36774: (QA Follow-up): Use flatpickr clear > >Im not sure why, but with the way it was before, there was a bug in my test plan. >If you cleared using the TEST link, and then input some date and clear with the 'x', a JS error would occurr. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >index c343e5e5dff..83a7432f7a5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >@@ -75,7 +75,7 @@ > .addClass("clear_date") > .on("click", function(e){ > e.preventDefault(); >- instance.clear(); >+ instance.input.flatpickr().clear(); > }) > .addClass("fa fa-fw fa-times") > .attr("aria-hidden", true) >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36774
:
166138
|
166139
|
166162
|
166163
|
166278
|
166303
|
166304
|
166305
|
166383
|
166384
|
166385
|
166395
|
166396
|
166423
|
166424
|
166425
|
166427
|
166463
|
166464