Attachment 166402 Details for Bug 35138 – Bug 35138: (follow-up) Mark DisplayLibraryFacets as zebra only

[patch] Bug 35138: (follow-up) Mark DisplayLibraryFacets as zebra only

Bug-35138-follow-up-Mark-DisplayLibraryFacets-as-z.patch (text/plain), 2.43 KB, created by Jonathan Druart on 2024-05-08 12:36:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-05-08 12:36:18 UTC

Size: 2.43 KB

patch

obsolete

>From fe1017dbbb6b53063d6bf81efe5ab6031b69f822 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 8 May 2024 14:35:11 +0200
>Subject: [PATCH] Bug 35138: (follow-up) Mark DisplayLibraryFacets as zebra
> only
>
>The tests are no longer relevant
>---
> .../SearchEngine/Elasticsearch/QueryBuilder.t | 21 +------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
>
>diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>index e834187ba64..c8c774d6e12 100755
>--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>@@ -219,7 +219,7 @@ subtest 'build_authorities_query_compat() tests' => sub {
> };
> 
> subtest 'build_query tests' => sub {
>-    plan tests => 63;
>+    plan tests => 57;
> 
>     my $qb;
> 
>@@ -254,25 +254,6 @@ subtest 'build_query tests' => sub {
>     is( $query->{aggregations}{homebranch}{terms}{size}, 37,'we ask for the size as defined by the syspref FacetMaxCount for homebranch');
>     is( $query->{aggregations}{holdingbranch}{terms}{size}, 37,'we ask for the size as defined by the syspref FacetMaxCount for holdingbranch');
> 
>-    t::lib::Mocks::mock_preference('DisplayLibraryFacets','both');
>-    $query = $qb->build_query();
>-    ok( defined $query->{aggregations}{homebranch},
>-        'homebranch added to facets if DisplayLibraryFacets=both' );
>-    ok( defined $query->{aggregations}{holdingbranch},
>-        'holdingbranch added to facets if DisplayLibraryFacets=both' );
>-    t::lib::Mocks::mock_preference('DisplayLibraryFacets','holding');
>-    $query = $qb->build_query();
>-    ok( !defined $query->{aggregations}{homebranch},
>-        'homebranch not added to facets if DisplayLibraryFacets=holding' );
>-    ok( defined $query->{aggregations}{holdingbranch},
>-        'holdingbranch added to facets if DisplayLibraryFacets=holding' );
>-    t::lib::Mocks::mock_preference('DisplayLibraryFacets','home');
>-    $query = $qb->build_query();
>-    ok( defined $query->{aggregations}{homebranch},
>-        'homebranch added to facets if DisplayLibraryFacets=home' );
>-    ok( !defined $query->{aggregations}{holdingbranch},
>-        'holdingbranch not added to facets if DisplayLibraryFacets=home' );
>-
>     t::lib::Mocks::mock_preference( 'QueryAutoTruncate', '' );
> 
>     ( undef, $query ) = $qb->build_query_compat( undef, ['donald duck'] );
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35138: 163133 | 163680 | 163681 | 163682 | 163683 | 163684 | 163896 | 163897 | 163898 | 163899 | 163900 | 164811 | 164812 | 164813 | 164814 | 164815 | 164816 | 165811 | 165812 | 165813 | 165814 | 165815 | 165816 | 165817 | 165818 | 166402