Attachment 166408 Details for Bug 36608 – Bug 36608: Adjust TO_PROCESS and AVAILABLE to use TT

[patch] Bug 36608: Adjust TO_PROCESS and AVAILABLE to use TT

Bug-36608-Adjust-TOPROCESS-and-AVAILABLE-to-use-TT.patch (text/plain), 4.56 KB, created by Martin Renvoize (ashimema) on 2024-05-08 13:07:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-08 13:07:31 UTC

Size: 4.56 KB

patch

obsolete

>From 1f7d820fbbcd4e1c0458798fb4f4644966082f53 Mon Sep 17 00:00:00 2001
>From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Date: Thu, 25 Apr 2024 16:17:41 -0400
>Subject: [PATCH] Bug 36608: Adjust TO_PROCESS and AVAILABLE to use TT
>
>To test:
>1. Apply patch
>2. reset_all (or start your testing environment in the first place)
>3. Go to "my account", and enter a Primary email
>4. Under Administration > Libraries, enter an email address for at least
>   one library
>5. Add the demo user (koha) as the owner of the Main Fund
>    a) Go to the Acquisitions module
>    b) Click on Main Fund
>    c) Click the Actions button at the end of Main Fund row > click Edit
>    d) Click "Select owner"
>    e) Search for "koha"
>    f) Click the Select button
>    g) Click Submit
>6. Click "Suggestions" on the left side of the page, and click "New
>   purchase suggestion"
>7. Fill in values for, at minimum:
>    Bibliographic information:
>        Title
>        Author
>    Acquisition information:
>        Library (set to the library you entered an email for in step 4)
>        Fund (set to Main Fund)
>9. Submit the suggestion
>10. Run the cron job to generate TO_PROCESS notification email:
>misc/cronjobs/notice_unprocessed_suggestions.pl -v -c --days=0
>11. Set the new suggestion to "Accepted"
>    a) Check the checkbox next to the new suggestion
>    b) Below the table, set "Mark selected as" drop-down to "Accepted"
>    c) Click Submit
>12. Create an order from the purchase suggestion
>    a) Return to the Acquisitions homepage
>    b) Leave the Vendor field blank and click Search
>    c) Next to the sample basket (My Basket), click "Add to basket"
>    d) Click "From a suggestion"
>    e) Click "+ Order" next to the suggestion
>    f) Make sure there are values for all required item fields
>    g) Click "Add item"
>    h) Click Save
>13. Close the basket and receive the order
>    a) Click "Close basket" and click "Yes, close"
>    b) Click "Receive shipments"
>    c) Enter a number in "Vendor invoice" and click Next
>    d) Check the checkbox next to "My Basket" and click "Receive
>       selected" button
>    e) Check the checkbox under "Receive?" in the Items table
>    f) Click Confirm
>14. Return to "my account" and open the Notices tab
>--> There should be (among others) notices for "A suggestion is ready to
>    be processed" and "Suggested purchase available"
>15. Open each of the above two notices, and confirm all the information
>    was filled in correctly
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/en/mandatory/sample_notices.yml     | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 9675b3eb4f1..4dcf3aa1d4d 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -1983,17 +1983,17 @@ tables:
>           message_transport_type: email
>           lang: default
>           content:
>-            - "Dear <<borrowers.firstname>> <<borrowers.surname>>,"
>+            - "Dear [% borrower.firstname %] [% borrower.surname %],"
>             - ""
>-            - "You have suggested that the library acquire <<suggestions.title>> by <<suggestions.author>>."
>+            - "You have suggested that the library acquire [% suggestion.title %] by [% suggestion.author %]."
>             - ""
>             - "We are pleased to inform you that the item you requested is now part of the collection."
>             - ""
>-            - "If you have any questions, please email us at <<branches.branchemail>>."
>+            - "If you have any questions, please email us at [% branch.branchemail %]."
>             - ""
>             - "Thank you,"
>             - ""
>-            - "<<branches.branchname>>"
>+            - "[% branch.branchname %]"
> 
>         - module: suggestions
>           code: NEW_SUGGESTION
>@@ -2085,13 +2085,13 @@ tables:
>           message_transport_type: email
>           lang: default
>           content:
>-            - "Dear <<borrowers.firstname>> <<borrowers.surname>>,"
>+            - "Dear [% borrower.firstname %] [% borrower.surname %],"
>             - ""
>-            - "A new suggestion is ready to be processed: <<suggestions.title>> by <<suggestions.author>>."
>+            - "A new suggestion is ready to be processed: [% suggestion.title %] by [% suggestion.author %]."
>             - ""
>             - "Thank you,"
>             - ""
>-            - "<<branches.branchname>>"
>+            - "[% branch.branchname %]"
> 
>         - module: suggestions
>           code: NOTIFY_MANAGER
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 36608: 165590 | 166408