Attachment 166415 Details for Bug 36106 – Bug 36106: Adjust DUE and PREDUE notices to use TT

[patch] Bug 36106: Adjust DUE and PREDUE notices to use TT

Bug-36106-Adjust-DUE-and-PREDUE-notices-to-use-TT.patch (text/plain), 3.71 KB, created by Martin Renvoize (ashimema) on 2024-05-08 13:19:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-08 13:19:48 UTC

Size: 3.71 KB

patch

obsolete

>From b79473aa76cfb7c47428fa688d2d733ef7126c1f Mon Sep 17 00:00:00 2001
>From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Date: Thu, 25 Apr 2024 16:54:16 -0400
>Subject: [PATCH] Bug 36106: Adjust DUE and PREDUE notices to use TT
>
>To test:
>1. Apply patch
>2. reset_all (or start your testing environment in the first place)
>3. Enable SMS Notices
>    a) Find the system preference SMSSendDriver
>    b) Enter "Email" as the value for SMSSendDriver and save
>4. Go to a patron account, and set the following messaging preferences:
>    Item due:
>        - Check SMS
>        - Check Email
>        - Leave Digests only unchecked
>    Advance notice
>        - Select 1 day in advance
>        - Check SMS
>        - Check Email
>        - Leave Digests only unchecked
>5. Go to the checkout tab for that patron
>6. Set a custom due date for today and check out an item
>7. Set a custom due date for tomorrow and check out another item
>8. Run the cron job to generate notices:
>   misc/cronjobs/advance_notices.pl -v -c
>9. Open the Notices tab on that patron's account
>--> The patron should have four notices:
>    Item due reminder (one for SMS and one for email)
>    Advance notice of item due (one for SMS and one for email)
>10. Open each notice and confirm that all information is correct
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/en/mandatory/sample_notices.yml   | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 9675b3eb4f1..8d225ed4749 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -617,11 +617,11 @@ tables:
>           message_transport_type: email
>           lang: default
>           content:
>-            - "Dear <<borrowers.firstname>> <<borrowers.surname>>,"
>+            - "Dear [% borrower.firstname %] [% borrower.surname %],"
>             - ""
>             - "The following item is now due:"
>             - ""
>-            - "<<biblio.title>>, <<biblio.author>> (<<items.barcode>>)"
>+            - "[% biblio.title %], [% biblio.author %] ([% item.barcode %])"
> 
>         - module: circulation
>           code: DUE
>@@ -632,11 +632,11 @@ tables:
>           message_transport_type: sms
>           lang: default
>           content:
>-            - "Dear <<borrowers.firstname>> <<borrowers.surname>>,"
>+            - "Dear [% borrower.firstname %] [% borrower.surname %],"
>             - ""
>             - "The following item is now due:"
>             - ""
>-            - "<<biblio.title>>"
>+            - "[% biblio.title %]"
> 
>         - module: circulation
>           code: DUEDGST
>@@ -833,11 +833,11 @@ tables:
>           message_transport_type: email
>           lang: default
>           content:
>-            - "Dear <<borrowers.firstname>> <<borrowers.surname>>,"
>+            - "Dear [% borrower.firstname %] [% borrower.surname %],"
>             - ""
>             - "The following item will be due soon:"
>             - ""
>-            - "<<biblio.title>>, <<biblio.author>> (<<items.barcode>>)"
>+            - "[% biblio.title %], [% biblio.author %] ([% item.barcode %])"
> 
>         - module: circulation
>           code: PREDUE
>@@ -848,11 +848,11 @@ tables:
>           message_transport_type: sms
>           lang: default
>           content:
>-            - "Dear <<borrowers.firstname>> <<borrowers.surname>>,"
>+            - "Dear [% borrower.firstname %] [% borrower.surname %],"
>             - ""
>             - "The following item will be due soon:"
>             - ""
>-            - "<<biblio.title>>"
>+            - "[% biblio.title %]"
> 
>         - module: circulation
>           code: PREDUEDGST
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 36106: 165591 | 166415