Bugzilla – Attachment 166418 Details for
Bug 36735
Cannot revert the waiting status of a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36735: (follow-up) Fix TT filters and add a comment
Bug-36735-follow-up-Fix-TT-filters-and-add-a-comme.patch (text/plain), 2.89 KB, created by
Emily Lamancusa
on 2024-05-08 13:40:31 UTC
(
hide
)
Description:
Bug 36735: (follow-up) Fix TT filters and add a comment
Filename:
MIME Type:
Creator:
Emily Lamancusa
Created:
2024-05-08 13:40:31 UTC
Size:
2.89 KB
patch
obsolete
>From 50f8ae743156c8e164dbe2685f7466f427e7a55a Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Mon, 6 May 2024 12:04:39 -0400 >Subject: [PATCH] Bug 36735: (follow-up) Fix TT filters and add a comment > >holds_table.inc depends on form-submit.js, but importing the asset >directly breaks the script. Add a comment stating that any script that >imports holds_table.inc must import form-submit.js too. > >Also change uri filters to html >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 1890c56115..b532ff9fe7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -1,6 +1,10 @@ > [% USE Koha %] > [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %] > [% USE AuthorisedValues %] >+ >+[% #This include depends on the asset js/form-submit.js. Any template making use of this include must import form-submit.js as well. %] >+[% #FIXME can form-submit.js be imported into this file directly? %] >+ > <table id="patron_holds_table" class="holds_table"> > <thead> > <tr> >@@ -257,7 +261,7 @@ > [%- END -%] > [%- END # IF SuspendHoldsIntranet -%] > [%- IF ( hold.found ) -%] >- <a class="btn btn-default submit-form-link" href="#" id="revert_hold_[% hold.reserve_id | html %]" data-op="cud-move" data-where="down" data-first_priority="[% first_priority | uri %]" data-last_priority="[% last_priority | uri %]" data-prev_priority="0" data-next_priority="1" data-borrowernumber="[% hold.borrowernumber | uri %]" data-biblionumber="[% hold.biblionumber | uri %]" data-itemnumber="[% hold.itemnumber | uri %]" data-reserve_id="[% hold.reserve_id | uri %]" data-date="[% hold.date | uri %]" data-action="request.pl" data-method="post">[% IF hold.intransit %]Revert transit status[% ELSE %]Revert waiting status[% END %]</a> >+ <a class="btn btn-default submit-form-link" href="#" id="revert_hold_[% hold.reserve_id | html %]" data-op="cud-move" data-where="down" data-first_priority="[% first_priority | html %]" data-last_priority="[% last_priority | html %]" data-prev_priority="0" data-next_priority="1" data-borrowernumber="[% hold.borrowernumber | html %]" data-biblionumber="[% hold.biblionumber | html %]" data-itemnumber="[% hold.itemnumber | html %]" data-reserve_id="[% hold.reserve_id | html %]" data-date="[% hold.date | html %]" data-action="request.pl" data-method="post">[% IF hold.intransit %]Revert transit status[% ELSE %]Revert waiting status[% END %]</a> > [%- END -%] > </td> > [% IF ( hold.intransit || hold.atdestination ) %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36735
:
165930
|
165931
|
166418
|
166552
|
166553