Bugzilla – Attachment 166448 Details for
Bug 36687
itemtypes.notforloan should be tinyint and NOT NULL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36687: (RM follow-up) Fix more unit tests
Bug-36687-RM-follow-up-Fix-more-unit-tests.patch (text/plain), 1.38 KB, created by
Martin Renvoize (ashimema)
on 2024-05-09 08:11:54 UTC
(
hide
)
Description:
Bug 36687: (RM follow-up) Fix more unit tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-05-09 08:11:54 UTC
Size:
1.38 KB
patch
obsolete
>From 2eaefa72f16ae6cea68305f62797cad940f43258 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 9 May 2024 08:58:46 +0100 >Subject: [PATCH] Bug 36687: (RM follow-up) Fix more unit tests > >Use currency.active to test `int(1) DEFAULT NULL` now that itemtypes.notforloan >is `NOT NULL DEFAULT '0'` > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Object.t | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index 92763c56990..28ac6e5e94b 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -1001,9 +1001,17 @@ subtest 'store() tests' => sub { > }; > is( $@, '', 'No error should be raised by ->store if empty strings are passed' ); > is( $itemtype->rentalcharge, undef, 'decimal DEFAULT NULL should default to null'); >- is( $itemtype->notforloan, undef, 'int DEFAULT NULL should default to null'); > is( $itemtype->hideinopac, 0, 'int NOT NULL DEFAULT 0 should default to 0'); > >+ my $currency = eval { >+ Koha::Acquisition::Currency->new( >+ { >+ active => 'IT4test', >+ } >+ )->store; >+ }; >+ is( $currency->active, undef, 'int DEFAULT NULL should default to null'); >+ > subtest 'Bad value tests' => sub { > > plan tests => 3; >-- >2.45.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36687
:
165483
|
165484
|
165819
|
165820
|
165840
|
165841
|
166257
|
166413
|
166414
|
166447
| 166448