Attachment 166468 Details for Bug 36775 – Bug 36775: Allow multiple holds on record when holds per record is unlimited

[patch] Bug 36775: Allow multiple holds on record when holds per record is unlimited

Bug-36775-Allow-multiple-holds-on-record-when-hold.patch (text/plain), 1.95 KB, created by Emily Lamancusa (emlam) on 2024-05-09 16:42:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2024-05-09 16:42:32 UTC

Size: 1.95 KB

patch

obsolete

>From b864fb1b21d20431fc65c147857a624cb3286555 Mon Sep 17 00:00:00 2001
>From: Andrew Fuerste Henry <andrewfh@dubcolib.org>
>Date: Thu, 9 May 2024 16:00:12 +0000
>Subject: [PATCH] Bug 36775: Allow multiple holds on record when holds per
> record is unlimited
>
>To test:
>1 set Holds Per Record to Unlimited
>2 confirm hold placement interface does not include "Holds to place (count)"
>3 apply patch, restart all
>4 reload hold placement interface, confirm it does include "Holds to place (count)"
>5 set Holds Per Record to 2
>6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second
>7 set Holds Per Record to 1
>8 confirm Holds to Place does not show
>9 sign off and eat a nice snack
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index a0ee80559f..f8c42090e5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -664,7 +664,7 @@
>                                                 </select>
>                                             </li>
>                                         [% END %]
>-                                        [% IF remaining_holds_for_record > 1 %]
>+                                        [% UNLESS remaining_holds_for_record == 1 %]
>                                             <li>
>                                                 <label for="holds_to_place_count">Holds to place (count)</label>
>                                                 <input type="text" inputmode="numeric" pattern="[0-9]*" id="holds_to_place_count" name="holds_to_place_count" maxlength="[% remaining_holds_for_record | html %]" value="1" />
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 36775: 166152 | 166158 | 166467 | 166468 | 166469