Bugzilla – Attachment 166469 Details for
Bug 36775
Option to place multiple holds on single bib should not be hidden when holds per record is unlimited
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36775: (QA follow-up) Remove max_length attribute
Bug-36775-QA-follow-up-Remove-maxlength-attribute.patch (text/plain), 1.82 KB, created by
Emily Lamancusa (emlam)
on 2024-05-09 16:42:34 UTC
(
hide
)
Description:
Bug 36775: (QA follow-up) Remove max_length attribute
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2024-05-09 16:42:34 UTC
Size:
1.82 KB
patch
obsolete
>From adff202cfaaed03c896ebd87cdce1ff3dffb5d36 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Thu, 9 May 2024 12:32:35 -0400 >Subject: [PATCH] Bug 36775: (QA follow-up) Remove max_length attribute > >The existing code for "Holds to place (count)" sets the input field's >maxlength to remaining_holds_for_record, which does not do what we want >and makes the field unusable when the circulation rules allow unlimited >holds. Better to remove it. > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index f8c42090e5..f3073eec17 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -667,7 +667,7 @@ > [% UNLESS remaining_holds_for_record == 1 %] > <li> > <label for="holds_to_place_count">Holds to place (count)</label> >- <input type="text" inputmode="numeric" pattern="[0-9]*" id="holds_to_place_count" name="holds_to_place_count" maxlength="[% remaining_holds_for_record | html %]" value="1" /> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" id="holds_to_place_count" name="holds_to_place_count" value="1" /> > </li> > [% ELSE %] > <input type="hidden" name="holds_to_place_count" value="1" /> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36775
:
166152
|
166158
|
166467
|
166468
| 166469