Attachment 166507 Details for Bug 36018 – Bug 36018: (follow-up) Disambiguate quantity

[patch] Bug 36018: (follow-up) Disambiguate quantity

Bug-36018-follow-up-Disambiguate-quantity.patch (text/plain), 1.18 KB, created by Martin Renvoize (ashimema) on 2024-05-10 08:15:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-10 08:15:51 UTC

Size: 1.18 KB

patch

obsolete

>From 9954e513bf755801a9f223d64e2622b1f4978991 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 19 Apr 2024 07:21:57 +0000
>Subject: [PATCH] Bug 36018: (follow-up) Disambiguate quantity
>
>One of the embeds refers to suggestions. This table also has
>a quantity column.
>
>Test plan:
>Verify that Pending Orders table does load now instead of
>triggering an internal server error on ambiguous column.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Acquisition/Orders.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Acquisition/Orders.pm b/Koha/Acquisition/Orders.pm
>index 2e8a9070e30..0911981cd7f 100644
>--- a/Koha/Acquisition/Orders.pm
>+++ b/Koha/Acquisition/Orders.pm
>@@ -166,7 +166,7 @@ sub filter_by_active {
>                   'orderstatus' => [ 'new', 'ordered', 'partial' ] },
>                 { 'orderstatus' => [ 'ordered', 'partial' ] }
>             ],
>-            quantityreceived => { '<', \['COALESCE(quantity,0)'] },
>+            quantityreceived => { '<', \['COALESCE(me.quantity,0)'] },
>         },
>         { join => 'basket' }
>     );
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 36018: 162318 | 162320 | 162321 | 163769 | 163770 | 163771 | 163772 | 164953 | 164954 | 164955 | 164956 | 165153 | 166503 | 166504 | 166505 | 166506 | 166507 | 166677