Bugzilla – Attachment 166521 Details for
Bug 35145
Add ability to order patron attributes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35145: (follow-up) Fix atomicupdate file and display_order's data type
Bug-35145-follow-up-Fix-atomicupdate-file-and-disp.patch (text/plain), 2.03 KB, created by
Pedro Amorim
on 2024-05-10 09:43:21 UTC
(
hide
)
Description:
Bug 35145: (follow-up) Fix atomicupdate file and display_order's data type
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-05-10 09:43:21 UTC
Size:
2.03 KB
patch
obsolete
>From 933aa03571dab79562e5b9e5e1a93803a7d74633 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Thu, 9 May 2024 20:08:34 +0000 >Subject: [PATCH] Bug 35145: (follow-up) Fix atomicupdate file and > display_order's data type > >PA amended: Added DEFAULT NULL COMMENT 'the order in which this attribute type appears in patron form' >to column entry to match what's in kohastructure.sql > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > Koha/Schema/Result/BorrowerAttributeType.pm | 2 +- > .../mysql/atomicupdate/bug_35145_order_patron_attributes.pl | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/Koha/Schema/Result/BorrowerAttributeType.pm b/Koha/Schema/Result/BorrowerAttributeType.pm >index 6da0b23f84..a80886a1cd 100644 >--- a/Koha/Schema/Result/BorrowerAttributeType.pm >+++ b/Koha/Schema/Result/BorrowerAttributeType.pm >@@ -187,7 +187,7 @@ __PACKAGE__->add_columns( > "mandatory", > { data_type => "tinyint", default_value => 0, is_nullable => 0 }, > "display_order", >- { data_type => "int", is_nullable => 1 }, >+ { data_type => "integer", is_nullable => 1 }, > ); > > =head1 PRIMARY KEY >diff --git a/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl b/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl >index b1650cd378..b6b7ef29c8 100755 >--- a/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl >+++ b/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl >@@ -11,12 +11,13 @@ return { > $dbh->do( > q{ > ALTER TABLE borrower_attribute_types >- ADD display_order int(11); >+ ADD COLUMN IF NOT EXISTS display_order int(11) DEFAULT NULL COMMENT >+ 'the order in which this attribute type appears in patron form' > } > ); > > # Print useful stuff here > # tables >- say $out "Added column 'borrower_attribute_types.number'"; >+ say $out "Added column 'borrower_attribute_types.display_order'"; > }, > }; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35145
:
159182
|
159193
|
159344
|
159345
|
162347
|
162348
|
162619
|
162620
|
162621
|
162622
|
162676
|
166473
|
166519
|
166520
|
166521
|
169256
|
169257
|
169258
|
170330
|
170331
|
170332
|
170627
|
170628
|
170629
|
176756
|
176757
|
176758
|
176760
|
176761
|
176762
|
176763
|
176764
|
176765
|
177119