Attachment 166526 Details for Bug 36129 – Bug 36129: Make check on "Hide all columns" persist on item patch modification/deletion

[patch] Bug 36129: Make check on "Hide all columns" persist on item patch modification/deletion

Bug-36129-Make-check-on-Hide-all-columns-persist-o.patch (text/plain), 1.68 KB, created by David Nind on 2024-05-10 09:55:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-05-10 09:55:46 UTC

Size: 1.68 KB

patch

obsolete

>From f6cea8166e9b1fd6cb2b26532cd5d45cf9f821b7 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Mon, 19 Feb 2024 12:55:26 +0200
>Subject: [PATCH] Bug 36129: Make check on "Hide all columns" persist on item
> patch modification/deletion
>
>On item patch modification/deletion tool, if one checks
>"Hide all columns" checkbox and then reloads the page,
>checkbox is no longer selected. Columns are hidden as
>they should. This patch adds line to batchMod.js which
>sets "checked" attribute and class "selected" to checkbox.
>
>To test:
>1. Find items to modify/delete and modify/delete them with
>corresponding tool.
>2. Check checkbox "Hide all columns".
>3. Refresh the page.
>=> Note that columns are still hidden, but checkbox is now
>unselected.
>4. Apply this patch.
>5. Check checkbox again and refresh page.
>=> Checkbox should be still checked.
>
>Sponsored-by: Koha-Suomi Oy
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js b/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js
>index 128c37909f..df428f831b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js
>@@ -20,6 +20,7 @@ function hideColumns() {
>     if (valCookie) {
>         valCookie = valCookie.split("/");
>         $("#showall").prop("checked", false).parent().removeClass("selected");
>+        $("#hideall").prop("checked", true).parent().addClass("selected");
>         for ( var i = 0; i < valCookie.length; i++ ) {
>             if (valCookie[i] !== '') {
>                 var index = valCookie[i] - nb_cols;
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36129: 162268 | 166526 | 169251