Attachment 166539 Details for Bug 35994 – Bug 35994: (QA follow-up) Fix Biblio.t

[patch] Bug 35994: (QA follow-up) Fix Biblio.t

Bug-35994-QA-follow-up-Fix-Bibliot.patch (text/plain), 1.34 KB, created by Martin Renvoize (ashimema) on 2024-05-10 12:28:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-10 12:28:23 UTC

Size: 1.34 KB

patch

obsolete

>From 971fe58f063794084c7de25d30843a1da29f4a92 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 10 May 2024 08:37:32 +0000
>Subject: [PATCH] Bug 35994: (QA follow-up) Fix Biblio.t
>
>A follow-up changed orders->cancel a bit. This test assumed to
>cancel completed lines here. So we are doing it now with a
>direct update to have the original result.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Koha/Biblio.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t
>index 56c58f1535c..9dda4f9f829 100755
>--- a/t/db_dependent/Koha/Biblio.t
>+++ b/t/db_dependent/Koha/Biblio.t
>@@ -999,7 +999,7 @@ subtest '->orders, ->uncancelled_orders and ->acq_status tests' => sub {
>     is( $biblio->acq_status, 'processing', 'Still processing for presence of new lines' );
>     $orders->filter_out_cancelled->update( { orderstatus => 'complete' } );
>     is( $biblio->acq_status, 'acquired', 'Acquired: some complete, rest cancelled' );
>-    $orders->cancel;
>+    $orders->update( { orderstatus => 'cancelled', datecancellationprinted => dt_from_string() } );
>     is( $biblio->acq_status, 'cancelled', 'Cancelled for only cancelled lines' );
> 
>     $schema->storage->txn_rollback;
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 35994: 162334 | 162335 | 165154 | 165155 | 165224 | 165225 | 166510 | 166537 | 166538 | 166539