Bugzilla – Attachment 166552 Details for
Bug 36735
Cannot revert the waiting status of a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36735: Fix revert hold button
Bug-36735-Fix-revert-hold-button.patch (text/plain), 3.50 KB, created by
Nick Clemens (kidclamp)
on 2024-05-10 12:56:40 UTC
(
hide
)
Description:
Bug 36735: Fix revert hold button
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-05-10 12:56:40 UTC
Size:
3.50 KB
patch
obsolete
>From b7a9d55f86848cd83d63ca0bfb85c9b9a5f40f5b Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Tue, 30 Apr 2024 15:32:13 -0400 >Subject: [PATCH] Bug 36735: Fix revert hold button > >Update the revert hold button to use the new include for submitting >forms from link data with a POST request > >To test: >1. Place a hold on a biblio record >2. Check an item in to fill the hold >3. On the holds tab for the biblio record, click the "Revert waiting > status" button for that hold >--> The page reloads but the hold is still waiting >4. Apply patchset >5. Click to another page and then return to the holds tab (we don't want > to refresh the page and resend the request) >6. Click the "Revert waiting status" button for that hold >--> The hold should be reverted to pending status > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index e939247f4b2..1890c56115f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -257,7 +257,7 @@ > [%- END -%] > [%- END # IF SuspendHoldsIntranet -%] > [%- IF ( hold.found ) -%] >- <input type="button" id="revert_hold_[% hold.reserve_id | html %]" value="[% IF hold.intransit %]Revert transit status[% ELSE %]Revert waiting status[% END %]" onclick="window.location.href='request.pl?op=move&where=down&first_priority=[% first_priority | uri %]&last_priority=[% last_priority | uri %]&prev_priority=0&next_priority=1&borrowernumber=[% hold.borrowernumber | uri %]&biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]&reserve_id=[% hold.reserve_id | uri %]&date=[% hold.date | uri %]'"> >+ <a class="btn btn-default submit-form-link" href="#" id="revert_hold_[% hold.reserve_id | html %]" data-op="cud-move" data-where="down" data-first_priority="[% first_priority | uri %]" data-last_priority="[% last_priority | uri %]" data-prev_priority="0" data-next_priority="1" data-borrowernumber="[% hold.borrowernumber | uri %]" data-biblionumber="[% hold.biblionumber | uri %]" data-itemnumber="[% hold.itemnumber | uri %]" data-reserve_id="[% hold.reserve_id | uri %]" data-date="[% hold.date | uri %]" data-action="request.pl" data-method="post">[% IF hold.intransit %]Revert transit status[% ELSE %]Revert waiting status[% END %]</a> > [%- END -%] > </td> > [% IF ( hold.intransit || hold.atdestination ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index a0ee80559fd..4b0f6b0941f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1489,6 +1489,7 @@ > [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %] > [% INCLUDE 'select2.inc' %] > [% Asset.js("js/holds.js") | $raw%] >+ [% Asset.js("js/form-submit.js") | $raw%] > > [% SET url_biblio_params = "biblionumber=" _ biblionumbers.join("&biblionumber=") %] > [% IF multi_hold %] >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36735
:
165930
|
165931
|
166418
| 166552 |
166553