Bugzilla – Attachment 166554 Details for
Bug 33849
Duplicate patron warning resets patron's library if different than logged in user's library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33849: Do not reset new patrons home library when error occurs
Bug-33849-Do-not-reset-new-patrons-home-library-wh.patch (text/plain), 1.84 KB, created by
Nick Clemens (kidclamp)
on 2024-05-10 13:03:25 UTC
(
hide
)
Description:
Bug 33849: Do not reset new patrons home library when error occurs
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-05-10 13:03:25 UTC
Size:
1.84 KB
patch
obsolete
>From 759a0505b569524d16aa0b1cdfba22827091b169 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Thu, 4 Apr 2024 09:04:47 +0300 >Subject: [PATCH] Bug 33849: Do not reset new patrons home library when error > occurs > >While adding new patron, if patron is flagged as duplicate >or another error occurs and their home library differs from >library user is logged in, patrons home library resets as >logged in users library. This happens with all patrons >expect those with category type C. This patch removes checking >if patrons category type is C from code so that all category >types use previously chosen home library even if error occurs. > >To test: >1. Add new patron and set their library to a different >library than the one you're logged in. >2. Cause an error (wrong age, duplicate etc) while saving. >3. Attempt to save. >=> Note that patrons home library is set as one you're >logged in. >4. Apply this patch. >5. Repeat steps 1 to 3. >=> Note that patrons home library hasn't changed. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Esther <esther@bywatersolutions.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > members/memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index fe0d1beff0e..f6472346917 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -710,7 +710,7 @@ if (C4::Context->userenv && C4::Context->userenv->{'branch'}) { > $userbranch = C4::Context->userenv->{'branch'}; > } > >-if (defined ($data{'branchcode'}) and ( $op eq 'edit_form' || $op eq 'duplicate' || ( $op eq 'add_form' && $category->category_type eq 'C' ) )) { >+if (defined ($data{'branchcode'}) and ( $op eq 'edit_form' || $op eq 'duplicate' || $op eq 'add_form' )) { > $userbranch = $data{'branchcode'}; > } > $template->param( userbranch => $userbranch ); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33849
:
164404
|
164863
| 166554