Bugzilla – Attachment 166568 Details for
Bug 33737
Add bookings to patron details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33737: Fix undefined variable issues
Bug-33737-Fix-undefined-variable-issues.patch (text/plain), 2.58 KB, created by
Martin Renvoize (ashimema)
on 2024-05-10 14:15:59 UTC
(
hide
)
Description:
Bug 33737: Fix undefined variable issues
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-05-10 14:15:59 UTC
Size:
2.58 KB
patch
obsolete
>From 308ee4a91635b2d2135a125ed41835e2be410838 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Sun, 18 Feb 2024 17:25:33 +0000 >Subject: [PATCH] Bug 33737: Fix undefined variable issues > >This patch resolves the undefined bookings_table variable issue reported >and also further fixes a subsequent undefined timeline bug that was >exposed by the original fix. > >Signed-off-by: Esther Melander <esther@bywatersolutions.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 +--- > koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index e468079c1e5..cef6bfb4836 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -759,6 +759,7 @@ > table_settings_relatives_issues_table = [% TablesSettings.GetTableSettings( 'members', 'moremember', 'relatives-issues-table', 'json' ) | $raw %] > table_settings_holds_table = [% TablesSettings.GetTableSettings( 'members', 'moremember', 'holds-table', 'json' ) | $raw %] > >+ var bookings_table; > $(document).ready(function() { > $("#info_digests").tooltip(); > >@@ -778,7 +779,6 @@ > }); > > // Bookings >- var bookings_table; > // Load bookings table on tab selection > $("#bookings-tab").on( "click", function(){ > if ( !bookings_table ) { >@@ -858,8 +858,6 @@ > }, [], 0, { patron_id: "[% patron.borrowernumber | html %]", end_date: { ">=": today.toISOString() } }); > }; > }); >- // Bookings >- > }); > > function uncheck_sibling(me){ >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js >index 3b325f0fc55..03c9e0b83bb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js >@@ -20,7 +20,7 @@ $("#cancelBookingForm").on('submit', function(e) { > if (bookings_table) { > bookings_table.api().ajax.reload(); > } >- if (timeline) { >+ if (typeof timeline !== 'undefined') { > timeline.itemsData.remove(Number(booking_id)); > } > $('.bookings_count').html(parseInt($('.bookings_count').html(), 10)-1); >-- >2.45.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33737
:
161045
|
161046
|
161047
|
162253
|
162254
|
162255
|
162256
|
163557
|
164994
|
164995
|
164996
|
164997
|
166513
|
166514
|
166515
|
166516
|
166565
|
166566
|
166567
| 166568 |
166570
|
166573
|
166577