Attachment 166604 Details for Bug 36832 – Bug 36832: (bug 36791 follow-up) Allow authid=0

[patch] Bug 36832: (bug 36791 follow-up) Allow authid=0

Bug-36832-bug-36791-follow-up-Allow-authid0.patch (text/plain), 1.40 KB, created by Phil Ringnalda on 2024-05-10 18:57:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Ringnalda

Created: 2024-05-10 18:57:39 UTC

Size: 1.40 KB

patch

obsolete

>From 2b5a5707c1554a74e5c283a43f625c6ccbc0bda5 Mon Sep 17 00:00:00 2001
>From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Date: Fri, 10 May 2024 14:01:59 -0400
>Subject: [PATCH] Bug 36832: (bug 36791 follow-up) Allow authid=0
>
>To test:
>1. Go to the Authorities module and do a Z39.50 search that will return
>   results (e.g. a general subject heading)
>2. Import an authority record from the results
>--> Confirm that the record is imported into the editor
>3. Authorities > New, replace it via Z39.50, confirm it's imported
>4. Authorities > New, fill the required fields, confirm it saves
>5. Edit an existing authority, replace it via Z39.50, confirm it saves
>6. Edit an existing authority, replace authid=nn in the URL with a
>   number that doesn't exist like 1000000, confirm you get a 404 page
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>---
> authorities/authorities.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/authorities/authorities.pl b/authorities/authorities.pl
>index b2fad5d2a8..3b8a235636 100755
>--- a/authorities/authorities.pl
>+++ b/authorities/authorities.pl
>@@ -553,7 +553,7 @@ if ( $op eq 'cud-change-framework' ) {
> 
> my $dbh = C4::Context->dbh;
> my $authobj = Koha::Authorities->find($authid);
>-if ( defined $authid && !$authobj ) {
>+if ( $authid && !$authobj ) {
>     print $input->redirect("/cgi-bin/koha/errors/404.pl");    # escape early
>     exit;
> }
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 36832: 166592 | 166604 | 166605 | 166606 | 166613