Bugzilla – Attachment 166625 Details for
Bug 36378
Cannot stay logged in if AutoLocation is enabled but library's IP address is not set correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly
Bug-36378-Cannot-stay-logged-in-if-AutoLocation-is.patch (text/plain), 1.47 KB, created by
Martin Renvoize (ashimema)
on 2024-05-13 10:19:42 UTC
(
hide
)
Description:
Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-05-13 10:19:42 UTC
Size:
1.47 KB
patch
obsolete
>From dbc4887aa05649767f152be496a8b276fd71208e Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 20 Mar 2024 15:32:50 -0400 >Subject: [PATCH] Bug 36378: Cannot stay logged in if AutoLocation is enabled > but branch ip is not set correctly > >We can get into a scenario what a user cannot stay logged in for more than a single page load. >If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. > >Test Plan: >1) Set your branch ip to a space >2) Enable AutoLocation >3) Restart all the things! >4) Log out >5) Log in >6) Browse to another page >7) You are logged out >8) Apply patch >9) Repeat 1-6 >10) You are not logged out! > >Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Auth.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index e3478ea6913..608650937f8 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1220,6 +1220,7 @@ sub checkauth { > # we have to check they are coming from the right ip range > my $domain = $branches->{$branchcode}->{'branchip'}; > $domain =~ s|\.\*||g; >+ $domain =~ s/\s+//g; > if ( $ip !~ /^$domain/ ) { > $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie( > -name => 'CGISESSID', >-- >2.45.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36378
:
163576
|
163716
| 166625