Bugzilla – Attachment 166661 Details for
Bug 36825
Cannot hide "Protected" field via BorrowerUnwantedField system preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref
Bug-36825-Hide-Protected-field-via-BorrowerUnwante.patch (text/plain), 5.25 KB, created by
Lucas Gass
on 2024-05-13 22:39:08 UTC
(
hide
)
Description:
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2024-05-13 22:39:08 UTC
Size:
5.25 KB
patch
obsolete
>From 58811fc839efa6bc1368ddcfa8e82dc062856102 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Fri, 10 May 2024 08:31:42 +0300 >Subject: [PATCH] Bug 36825: Hide "Protected" field via BorrowerUnwantedField > syspref > >Setting field "Protected" as hidden in patron entry/modification >form via BorrowerUnwantedField syspref doesn't work. Form is >missing condition "UNLESS noprotected". > >To test: >1. From BorrowerUnwantedField, check field "Protected" as hidden. >2. Either attempt to create a new patron or modify existing one. >=> Note that "Protected" is still displayed in the form. >3. Apply this patch. >4. Navigate back to create/modify patron form. >=> Note that "Protected" is no longer displayed. >5. Uncheck field "Protected" from BorrowerUnwantedField. >=> Field should now be displayed in create/modify form. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../prog/en/modules/members/memberentrygen.tt | 46 ++++++++++--------- > 1 file changed, 24 insertions(+), 22 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 0d61794723..6877ef453f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1080,28 +1080,30 @@ legend.collapsed i.fa.fa-caret-down::before { > </li> > [% END %] > >- <li class="radio"> >- <label for="protected">Protected:</label> >- [% IF ( patron.protected == 1 ) %] >- <label for="yes-protected"> >- Yes >- <input type="radio" id="yes-protected" name="protected" value="1" checked="checked" /> >- </label> >- <label for="no-protected"> >- No >- <input type="radio" id="no-protected" name="protected" value="0" /> >- </label> >- [% ELSE %] >- <label for="yes-protected"> >- Yes >- <input type="radio" id="yes-protected" name="protected" value="1" /> >- </label> >- <label for="no-protected"> >- No >- <input type="radio" id="no-protected" name="protected" value="0" checked="checked" /> >- </label> >- [% END %] >- </li> >+ [% UNLESS noprotected %] >+ <li class="radio"> >+ <label for="protected">Protected:</label> >+ [% IF ( patron.protected == 1 ) %] >+ <label for="yes-protected"> >+ Yes >+ <input type="radio" id="yes-protected" name="protected" value="1" checked="checked" /> >+ </label> >+ <label for="no-protected"> >+ No >+ <input type="radio" id="no-protected" name="protected" value="0" /> >+ </label> >+ [% ELSE %] >+ <label for="yes-protected"> >+ Yes >+ <input type="radio" id="yes-protected" name="protected" value="1" /> >+ </label> >+ <label for="no-protected"> >+ No >+ <input type="radio" id="no-protected" name="protected" value="0" checked="checked" /> >+ </label> >+ [% END %] >+ </li> >+ [% END %] > > [% IF ( Koha.Preference('CheckPrevCheckout') == 'softyes' || Koha.Preference('CheckPrevCheckout') == 'softno' ) %] > <li> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36825
:
166488
|
166586
| 166661