Bugzilla – Attachment 166682 Details for
Bug 35362
Update patron module pop-up windows with consistent footer markup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35362: Adjust other "Close window" clicks
Bug-35362-Adjust-other-Close-window-clicks.patch (text/plain), 1.50 KB, created by
Jonathan Druart
on 2024-05-14 09:52:03 UTC
(
hide
)
Description:
Bug 35362: Adjust other "Close window" clicks
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-05-14 09:52:03 UTC
Size:
1.50 KB
patch
obsolete
>From 18ba98d08bcf70b58729192c326d48f516a5b49d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 14 May 2024 11:51:11 +0200 >Subject: [PATCH] Bug 35362: Adjust other "Close window" clicks > >Previous patch "Bug 35362: (follow-up) Fix guaruntor preview modal close in test" >didn't adjust the other occurrences. >--- > t/db_dependent/selenium/patrons_search.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t >index ac8eb806239..e410c4833c5 100755 >--- a/t/db_dependent/selenium/patrons_search.t >+++ b/t/db_dependent/selenium/patrons_search.t >@@ -613,7 +613,7 @@ subtest 'Search patrons in modal' => sub { > ); > > # Close the patron preview modal >- $driver->find_element('//div[@id="patron_preview_modal"]//input[@class="close"]')->click; >+ $driver->find_element('//*[@id="patron_preview_modal"]/div[2]/fieldset/button')->click; > $s->wait_for_element_hidden('//div[@id="patron_preview_modal"]'); > > # Select patron 2 >@@ -675,7 +675,7 @@ subtest 'Search patrons in modal' => sub { > ); > > # Close the patron preview modal >- $driver->find_element('//div[@id="patron_preview_modal"]//input[@class="close"]')->click; >+ $driver->find_element('//*[@id="patron_preview_modal"]/div[2]/fieldset/button')->click; > $s->wait_for_element_hidden('//div[@id="patron_preview_modal"]'); > > # Select patron 2 >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35362
:
159096
|
159118
|
162390
|
165609
|
165610
| 166682