Bugzilla – Attachment 166683 Details for
Bug 24424
Advanced editor - interface hangs as "Loading" when given an invalid bib number
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24424: Advanced editor - interface hangs as "Loading" when given an invalid bib number
Bug-24424-Advanced-editor---interface-hangs-as-Loa.patch (text/plain), 2.31 KB, created by
Janusz Kaczmarek
on 2024-05-14 11:49:46 UTC
(
hide
)
Description:
Bug 24424: Advanced editor - interface hangs as "Loading" when given an invalid bib number
Filename:
MIME Type:
Creator:
Janusz Kaczmarek
Created:
2024-05-14 11:49:46 UTC
Size:
2.31 KB
patch
obsolete
>From 8d50a61266c9430c4a5ea67956b2b1cd2664b2b8 Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Tue, 14 May 2024 11:08:19 +0000 >Subject: [PATCH] Bug 24424: Advanced editor - interface hangs as "Loading" > when given an invalid bib number > >The Advanced Editor hangs with "Loading, please wait" message when given an >invalid bib number, e.g. /cgi-bin/koha/cataloguing/editor.pl#catalog/55555 > >This is because in the bug 16424, when changes had been made to >koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js >(Bug 16424: Add framework support to advanced MARC editor), >the .fail callback method of the outer .get (in the KohaBackend.GetRecord >function called from cateditor-ui.inc) had been (perhaps by mistake?) removed. >So, in case of failure, the situation is not handled properly. > >The proposal is to restore the outer .fail. As a result, the >openRecord( 'new/', editor, finishCb ); will be called (a standard way >of resolving failed openRecord action (cf. the bottom of cateditor-ui.inc). > >Test plan: >========== >0. Be sure your browser does not cache JavaScript for this test. >1. Enable EnableAdvancedCatalogingEditor in the system preferences. >2. Try to open in the advanced editor an unexisting record, e.g. > http://your_ktd:8081/cgi-bin/koha/cataloguing/editor.pl#catalog/55555 > Koha should hang with a message "Loading, please wait". >3. Apply the patch, restart_all. >4. In a new browser window, repeat p. 2 (remember not to cache JS). >5. The editor should open with a new empty record. > >Sponsored-by: Ignatianum University in Cracow >--- > koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js >index 0ac4980872..2e527d44b0 100644 >--- a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js >+++ b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js >@@ -134,6 +134,8 @@ define( [ '/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=defin > } ).fail( function( data ) { > callback( { error: _('Could not fetch frameworkcode for record') } ); > } ); >+ } ).fail( function( data ) { >+ callback( { error: data } ) > } ); > }, > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24424
:
166683
|
166690