Attachment 166748 Details for Bug 36610 – Bug 36610: Some improvements to OPAC print CSS

[patch] Bug 36610: Some improvements to OPAC print CSS

Bug-36610-Some-improvements-to-OPAC-print-CSS.patch (text/plain), 10.08 KB, created by Martin Renvoize (ashimema) on 2024-05-15 06:44:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-15 06:44:21 UTC

Size: 10.08 KB

patch

obsolete

>From 3a7810a15f591ac3515727ed4852be53cfc7f751 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 17 Apr 2024 12:55:04 +0000
>Subject: [PATCH] Bug 36610: Some improvements to OPAC print CSS
>
>This patch makes a few CSS and markup changes to improve the print view.
>
>The markup changes use Bootstrap's ".d-print-none" class to hide
>specific elements without creating an ID or class specifically for those
>elements.
>
>To test, apply the patch and rebuild the OPAC CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)
>
>- Log in to the OPAC
>- Test the following user pages by viewing the print preview:
>  - Summary
>  - Holds history
>  - Messaging
>  - Lists
>  - Suggestions
>- The "Personal details" tab hasn't been improved for printing but it's
>  a good page to view to confirm that the "Back to top" arrow is now
>  hidden in the print view.
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../opac-tmpl/bootstrap/css/src/print.scss    | 31 ++++++++++++++++++-
> .../bootstrap/en/includes/opac-note.inc       |  2 +-
> .../bootstrap/en/modules/opac-holdshistory.tt |  6 ++--
> .../bootstrap/en/modules/opac-messaging.tt    |  2 +-
> .../bootstrap/en/modules/opac-shelves.tt      |  2 +-
> .../bootstrap/en/modules/opac-suggestions.tt  |  2 +-
> .../bootstrap/en/modules/opac-user.tt         |  6 ++--
> 7 files changed, 40 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss
>index 73679604c9b..7ad3fd1902c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss
>@@ -221,6 +221,7 @@ body#basket p {
> 
> #action,
> #addshelf,
>+#backtotop,
> #consentMoreInfo,
> #cookieConsentFooter,
> #export,
>@@ -251,10 +252,38 @@ fieldset.action,
> h2 span.hint,
> input,
> td.resultscontrol,
>-.cart-control {
>+.cart-control,
>+.table_controls,
>+.dtr-control,
>+.dtr-hidden,
>+.selections-toolbar {
>     display: none;
> }
> 
>+.dtr-hidden {
>+    display: table-cell !important;
>+}
>+
>+.nav-tabs {
>+    border: 0;
>+
>+    .nav-link {
>+        border: 0;
>+        display: none;
>+
>+        &.active {
>+            border: 0;
>+            display: block;
>+            font-size: 125%;
>+            font-weight: bold;
>+        }
>+    }
>+}
>+
>+.tab-content {
>+    border: 0;
>+}
>+
> .row-fluid {
>     margin-top: 30px;
> }
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc
>index 71cea64f556..2cbc523382e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc
>@@ -7,7 +7,7 @@
>                     <strong>[% message.message | html | html_line_break %]</strong><br>
>                     &nbsp;&nbsp;&nbsp;<em>Written on [% message.message_date | $KohaDates %] by [% Branches.GetName(message.branchcode) | html %]</em>
>                 </li>
>-                <form id="dismiss-message-form" action="/cgi-bin/koha/opac-dismiss-message.pl" method="post">
>+                <form id="dismiss-message-form" class="d-print-none" action="/cgi-bin/koha/opac-dismiss-message.pl" method="post">
>                     [% INCLUDE 'csrf-token.inc' %]
>                     <input type="hidden" name="message_id" value="[% message.message_id | html %]">
>                     <input type="hidden" name="patron_id" value="[% message.borrowernumber | html %]">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>index 06d97bb7936..3e39a2725b5 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>@@ -71,7 +71,7 @@
>                         <div id="opac-user-holdsrec">
>                             <div id="tabs-container">
>                                 <div class="controls">
>-                                    <div class="resultscontrol resort">
>+                                    <div class="resultscontrol resort d-print-none">
>                                         <form id="sortform" action="/cgi-bin/koha/opac-holdshistory.pl" method="get">
>                                             [% IF ( unlimit ) %]<input type="hidden" name="unlimit" value="1" />[% END %]
>                                             <select name="sort" id="sort">
>@@ -84,11 +84,11 @@
>                                     </div>
> 
>                                     [% UNLESS unlimit %]
>-                                        <p>
>+                                        <p class="d-print-none">
>                                             Showing 50 items. <a href="/cgi-bin/koha/opac-holdshistory.pl?unlimit=1[% IF ( sort ) %]&amp;sort=[% sort | url %][% END %]">Show all items</a>
>                                         </p>
>                                     [% ELSE %]
>-                                        <p>
>+                                        <p class="d-print-none">
>                                             Showing all items. <a href="/cgi-bin/koha/opac-holdshistory.pl[% IF ( sort ) %]?sort=[% sort | url %][% END %]">Show 50 items</a>
>                                         </p>
>                                     [% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 1fa2975e9f6..84a5c79d27c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -182,7 +182,7 @@
>                             [% END %]
> 
>                             [% IF ( SMSSendDriver || Koha.Preference('TranslateNotices') ) %]
>-                                <fieldset class="rows">
>+                                <fieldset class="rows d-print-none">
>                                     <ol>
>                                         [% IF ( SMSSendDriver ) %]
>                                             <li>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 0adf9508105..0686b5d506b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -762,7 +762,7 @@
>                                                         [% END %]
>                                                     </td>
>                                                     <td>[% s.lastmodified | $KohaDates %]</td>
>-                                                    <td>
>+                                                    <td class="d-print-none">
>                                                         [% IF s.can_be_managed( loggedinusernumber ) %]
>                                                             <form action="/cgi-bin/koha/opac-shelves.pl" method="get" class="d-inline">
>                                                                 <input type="hidden" name="shelfnumber" value="[% s.shelfnumber | html %]" />
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 6bf1a4facbb..a1956df42b3 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -340,7 +340,7 @@
> 
>                             [% IF (Koha.Preference( 'OPACViewOthersSuggestions' ) || loggedinusername) && (suggestions.size > 0 OR title_filter) %]
>                                 [% SET can_delete_suggestion = 0 %]
>-                                <form action="/cgi-bin/koha/opac-suggestions.pl" class="form-inline" id="search_suggestions_form" method="get">
>+                                <form action="/cgi-bin/koha/opac-suggestions.pl" class="form-inline d-print-none" id="search_suggestions_form" method="get">
>                                     <div class="form-row">
>                                         <div class="col-auto my-1">
>                                             <label for="title_filter">Search for:</label>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index d9c63bebd9c..b9be5c22c52 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -55,7 +55,7 @@
> 
>                     <p>Hello, [% INCLUDE 'patron-title.inc' patron = logged_in_user %]
>                     <br />
>-                    <a href="/cgi-bin/koha/opac-main.pl?logout.x=1">Click here if you're not [% INCLUDE 'patron-title.inc' patron = logged_in_user %]</a></p>
>+                    <a href="/cgi-bin/koha/opac-main.pl?logout.x=1" class="d-print-none">Click here if you're not [% INCLUDE 'patron-title.inc' patron = logged_in_user %]</a></p>
> 
>                     [% IF ( patronupdate ) %]<div class="alert alert-info"><h2>Thank you!</h2><p>Your corrections have been submitted to the library, and a staff member will update your record as soon as possible.</p></div>[% END %]
> 
>@@ -551,9 +551,9 @@
>                                             </tbody>
>                                         </table>
>                                         [% IF ( canrenew && !userdebarred && OpacRenewalAllowed && !( logged_in_user.is_expired && logged_in_user.category.effective_BlockExpiredPatronOpacActions ) ) %]
>-                                            <input type="submit" class="btn btn-primary" value="Renew selected" />
>+                                            <input type="submit" class="btn btn-primary d-print-none" value="Renew selected" />
>                                             <input type="hidden" name="op" value="cud-renew" />
>-                                            <button type="button" id="renewall_js" class="btn btn-primary">Renew all</button>
>+                                            <button type="button" id="renewall_js" class="btn btn-primary d-print-none">Renew all</button>
>                                         [% END %]
>                                     </form>
> 
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 36610: 165025 | 165062 | 166748