Attachment 166788 Details for Bug 36862 – Bug 36862: Remove jQuery change() event

[patch] Bug 36862: Remove jQuery change() event

Bug-36862-Remove-jQuery-change-event.patch (text/plain), 1.36 KB, created by Lucas Gass (lukeg) on 2024-05-15 16:40:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-05-15 16:40:41 UTC

Size: 1.36 KB

patch

obsolete

>From 29f4ad5d87438ba6a992550c69be7fbbb792e3d0 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 15 May 2024 16:39:11 +0000
>Subject: [PATCH] Bug 36862: Remove jQuery change() event
>
>To test:
>1 - Search the catalog in the staff client and/or OPAC
>2 - Add 3 or more titles to the cart
>3 - Open the cart via the button in the top menu
>4 - Click "Select all"
>5 - Uncheck the first checkbox
>6 - Click "Clear all"
>7 - APPLY PATCH, clear browser cache
>8 - Try again, the browser should not crash.
>---
> koha-tmpl/intranet-tmpl/prog/js/cart.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/cart.js b/koha-tmpl/intranet-tmpl/prog/js/cart.js
>index 0514331af7..c02c403805 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/cart.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/cart.js
>@@ -68,14 +68,14 @@ $(document).ready(function(){
>     $("#CheckAll").click(function (e) {
>         e.preventDefault();
>         $(".select_record").each(function () {
>-            $(this).prop("checked", true).change();
>+            $(this).prop("checked", true);
>         });
>     });
> 
>     $("#CheckNone").click(function (e) {
>         e.preventDefault();
>         $(".select_record").each(function () {
>-            $(this).prop("checked", false).change();
>+            $(this).prop("checked", false);
>         });
>     });
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36862: 166788 | 166840