Bugzilla – Attachment 166797 Details for
Bug 36520
SQL Injection in opac-sendbasket.pl (CVE-2024-36058)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36520: Sanitize input in opac-sendbasket.pl
Bug-36520-Sanitize-input-in-opac-sendbasketpl.patch (text/plain), 1.52 KB, created by
Victor Grousset/tuxayo
on 2024-05-15 23:15:36 UTC
(
hide
)
Description:
Bug 36520: Sanitize input in opac-sendbasket.pl
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-05-15 23:15:36 UTC
Size:
1.52 KB
patch
obsolete
>From 3d4baf155e0e11b5dbf81bec60403757dde794d8 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chris@bigballofwax.co.nz> >Date: Mon, 13 May 2024 02:26:13 +0000 >Subject: [PATCH] Bug 36520: Sanitize input in opac-sendbasket.pl > >To test >1/ Add some items to your cart in the opac >2/ Choose send cart >3/ Open firefox developer tools and switch to the network tab >4/ Send cart >5/ In the network tab, find the post request and choose copy as curl >6/ Edit the curl command to add )+AND+(SELECT+1+FROM+(SELECT(SLEEP(6)))x)--+- to the bib_list parameter >7/ Run the curl notice it takes a long time to respond, if you want to check run the curl without the above part added >8/ Apply the patch and restart plack >9/ Run the modified curl and notice no longer the slow down >10/ Test in browser and make sure the basket is still sent > >Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > opac/opac-sendbasket.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl >index de984d01c3..e7bd2e42fa 100755 >--- a/opac/opac-sendbasket.pl >+++ b/opac/opac-sendbasket.pl >@@ -52,6 +52,7 @@ if ( $op eq "cud-send" && $email_add && $user_email ) { > my @bibs = split( /\//, $bib_list ); > my $iso2709; > foreach my $bib (@bibs) { >+ $bib = int($bib); > my $biblio = Koha::Biblios->find($bib) or next; > $iso2709 .= $biblio->metadata->record->as_usmarc(); > } >-- >2.45.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36520
:
166614
|
166617
|
166618
|
166620
|
166632
|
166633
|
166635
|
166646
|
166650
|
166760
|
166761
|
166762
|
166795
|
166796
|
166797
|
166861
|
166862
|
166863