Bugzilla – Attachment 166808 Details for
Bug 36880
Record overlay rules are not validated on add or edit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36880: Record overlay rules are not validated on add or edit
Bug-36880-Record-overlay-rules-are-not-validated-o.patch (text/plain), 1.56 KB, created by
Jan Kissig
on 2024-05-16 08:17:24 UTC
(
hide
)
Description:
Bug 36880: Record overlay rules are not validated on add or edit
Filename:
MIME Type:
Creator:
Jan Kissig
Created:
2024-05-16 08:17:24 UTC
Size:
1.56 KB
patch
obsolete
>From bfb4bf0d334a8d96b81956cfce1eb49bc034c5de Mon Sep 17 00:00:00 2001 >From: Jan Kissig <jkissig@th-wildau.de> >Date: Thu, 16 May 2024 10:11:53 +0200 >Subject: [PATCH] Bug 36880: Record overlay rules are not validated on add or > edit > >This patch fixes the validation of record overlay rules on operation add or edit. > >Testplan: > a) open http://localhost:8081/cgi-bin/koha/admin/marc-overlay-rules.pl > b) just click + Add rule > c) a new rule with an empty tag is saved > >apply patch: > a) open http://localhost:8081/cgi-bin/koha/admin/marc-overlay-rules.pl > b) just click + Add rule > c) the input for Tag gets marked as required >--- > .../intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >index 58a70e242b..6a5b45fc1b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >@@ -324,9 +324,9 @@ > } > > var valid = true; >- if (op == 'add' || op == 'edit') { >+ if (op == 'cud-add' || op == 'cud-edit') { > var validate = [ >- $('#marc-overlay-rules-form input[name="filter"]'), >+ $('#marc-overlay-rules-form select[name="filter"]'), > $('#marc-overlay-rules-form input[name="tag"]') > ]; > for(var i = 0; i < validate.length; i++) { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36880
:
166808
|
167182
|
167190
|
167207
|
167234
|
168088