Bugzilla – Attachment 166824 Details for
Bug 36877
Patron card creator does not work when editing layout, profile or template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl
Bug-36877-follow-up-Fix-op-eq-edit-to-op-eq-editfo.patch (text/plain), 2.06 KB, created by
Owen Leonard
on 2024-05-16 12:48:41 UTC
(
hide
)
Description:
Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in edit-batch.pl
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-05-16 12:48:41 UTC
Size:
2.06 KB
patch
obsolete
>From ed69a978d57ef29d0f2de0621860b5596dfcc091 Mon Sep 17 00:00:00 2001 >From: Jan Kissig <jkissig@th-wildau.de> >Date: Thu, 16 May 2024 14:37:16 +0200 >Subject: [PATCH] Bug 36877: (follow-up) Fix op eq edit to op eq edit_form in > edit-batch.pl > > Additionally removes fixme comments > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > patroncards/edit-batch.pl | 2 +- > patroncards/edit-profile.pl | 2 +- > patroncards/edit-template.pl | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/patroncards/edit-batch.pl b/patroncards/edit-batch.pl >index f3c183e9b0..3f41957cc6 100755 >--- a/patroncards/edit-batch.pl >+++ b/patroncards/edit-batch.pl >@@ -123,7 +123,7 @@ elsif ( $op eq 'cud-dedup' ) { > exit; > } > } >-elsif ($op eq 'edit') { #FIXME edit_form actually >+elsif ($op eq 'edit_form') { > $batch = C4::Patroncards::Batch->retrieve(batch_id => $batch_id); > $template->param( description => $batch->{'description'} ); > } >diff --git a/patroncards/edit-profile.pl b/patroncards/edit-profile.pl >index a41529c1b4..2cf29ddaca 100755 >--- a/patroncards/edit-profile.pl >+++ b/patroncards/edit-profile.pl >@@ -45,7 +45,7 @@ my @label_template = (); > > my $units = get_unit_values(); > >-if ($op eq 'edit_form') { # FIXME This looks like edit_form ? >+if ($op eq 'edit_form') { > $profile = C4::Patroncards::Profile->retrieve(profile_id => $profile_id); > $template_list = get_all_templates({ fields => [ qw( template_id template_code profile_id ) ] }); > } >diff --git a/patroncards/edit-template.pl b/patroncards/edit-template.pl >index 76901412d7..804a2ee5e7 100755 >--- a/patroncards/edit-template.pl >+++ b/patroncards/edit-template.pl >@@ -45,7 +45,7 @@ my $profile_list = undef; > > my $units = get_unit_values(); > >-if ($op eq 'edit_form') { # FIXME This looks like edit_form >+if ($op eq 'edit_form') { > $card_template = C4::Patroncards::Template->retrieve(template_id => $template_id); > $profile_list = get_all_profiles({ fields => [ qw( profile_id printer_name paper_bin ) ], filters => {template_id => [ $template_id, 0 ], creator => 'Patroncards'} } ); > } >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36877
:
166810
|
166822
|
166823
|
166824
|
166877
|
166878