Attachment 166836 Details for Bug 36798 – Bug 36798: Add 'SearchCancelAndInvalidISBNandISSN' system preference

[patch] Bug 36798: Add 'SearchCancelAndInvalidISBNandISSN' system preference

Bug-36798-Add-SearchCancelAndInvalidISBNandISSN-sy.patch (text/plain), 4.15 KB, created by Roman Dolny on 2024-05-16 17:52:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roman Dolny

Created: 2024-05-16 17:52:55 UTC

Size: 4.15 KB

patch

obsolete

>From 97cf7c36f7d5c70e153a285ef6c634f4403fd942 Mon Sep 17 00:00:00 2001
>From: Janusz Kaczmarek <januszop@gmail.com>
>Date: Tue, 14 May 2024 13:06:05 +0000
>Subject: [PATCH] Bug 36798: Add 'SearchCancelAndInvalidISBNandISSN' system
> preference
>
>This patch adds a new system preference SearchCancelAndInvalidISBNandISSN:
>whether to search for cancelled / invalid forms of ISBN/ISSN
>when performing ISBN/ISSN search. (By default, with ES, only valid forms,
>i.e.  020 $a / 022 $a are considered).
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>---
> .../data/mysql/atomicupdate/bug_36798.pl      | 21 +++++++++++++++++++
> installer/data/mysql/mandatory/sysprefs.sql   |  1 +
> .../modules/admin/preferences/searching.pref  |  7 +++++++
> 3 files changed, 29 insertions(+)
> create mode 100755 installer/data/mysql/atomicupdate/bug_36798.pl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_36798.pl b/installer/data/mysql/atomicupdate/bug_36798.pl
>new file mode 100755
>index 0000000000..f3dba64da0
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_36798.pl
>@@ -0,0 +1,21 @@
>+use Modern::Perl;
>+use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
>+
>+return {
>+    bug_number  => "36798",
>+    description => "Add `SearchCancelAndInvalidISBNandISSN` preference",
>+    up          => sub {
>+        my ($args) = @_;
>+        my ( $dbh, $out ) = @$args{qw(dbh out)};
>+
>+        # Do you stuffs here
>+        $dbh->do(
>+            q{
>+            INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` )
>+            VALUES ('SearchCancelAndInvalidISBNandISSN','0',NULL,'Enable search for cancelled or invalid forms of ISBN/ISSN when performing ISBN/ISSN search (when using ES)','YesNo')
>+            }
>+        );
>+
>+        say_success( $out, "Added new system preference 'SearchCancelAndInvalidISBNandISSN'" );
>+    },
>+};
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index 06ebba4511..83236d5ff9 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -686,6 +686,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('SCOLoadCheckoutsByDefault','1','','If enabled, load the list of a patrons checkouts when they log in to the Self Checkout','YesNo'),
> ('SCOUserCSS','',NULL,'Add CSS to be included in the SCO module in an embedded <style> tag.','free'),
> ('SCOUserJS','',NULL,'Define custom javascript for inclusion in the SCO module','free'),
>+('SearchCancelAndInvalidISBNandISSN','0',NULL,'Enable search for cancelled or invalid forms of ISBN/ISSN when performing ISBN/ISSN search (when using ES)','YesNo'),
> ('SearchEngine','Zebra','Elasticsearch|Zebra','Search Engine','Choice'),
> ('SearchLimitLibrary', 'homebranch', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice'),
> ('SearchMyLibraryFirst','0',NULL,'If ON, OPAC searches return results limited by the user\'s library by default if they are logged in','YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>index da202d7e1e..face33ddef 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>@@ -99,6 +99,13 @@ Searching:
>             - "List of search fields (separated by | or ,) that should not be autotruncated by Elasticsearch even if <a href='/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=QueryAutoTruncate'>QueryAutoTruncate</a> is set to 'Yes':"
>             - pref: ESPreventAutoTruncate
>               class: long
>+        -
>+            - pref: SearchCancelAndInvalidISBNandISSN
>+              default: 0
>+              choices:
>+                  1: Do
>+                  0: "Don't"
>+            - "search for cancelled or invalid forms of ISBN/ISSN when performing ISBN/ISSN search (when using Elasticsearch)."
>     Search form:
>         -
>             - pref: LoadSearchHistoryToTheFirstLoggedUser
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36798: 166828 | 166829 | 166830 | 166836 | 166837 | 166838 | 171906 | 171907 | 171908 | 171935 | 171936 | 171937