Attachment 166843 Details for Bug 34838 – [23.11.x] Bug 34838: Only check for status in status graph if request has a status

[patch] [23.11.x] Bug 34838: Only check for status in status graph if request has a status

2311x-Bug-34838-Only-check-for-status-in-status-gr.patch (text/plain), 1.52 KB, created by Tomás Cohen Arazi (tcohen) on 2024-05-16 20:24:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-05-16 20:24:47 UTC

Size: 1.52 KB

patch

obsolete

>From d64ea2b5e2f320f17ce92d5660cfde917f49f171 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Tue, 26 Sep 2023 09:35:01 +0000
>Subject: [PATCH] [23.11.x] Bug 34838: Only check for status in status graph if
> request has a status
>
>This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Illrequest.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 1496c45977c..f7ed9854d8e 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -1972,12 +1972,12 @@ sub strings_map {
>     }
> 
>     my $status_string =
>-      ( exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{name} )
>+      ( $self->status && exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{name} )
>       ? $status_graph_union->{ $self->status }->{name}
>       : $self->status;
> 
>     my $status_code =
>-      ( exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{id} )
>+      ( $self->status && exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{id} )
>       ? $status_graph_union->{ $self->status }->{id}
>       : $self->status;
> 
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 34838: 156178 | 156200 | 156201 | 156202 | 156204 | 156217 | 156218 | 156219 | 156220 | 166841 | 166842 | 166843 | 166844 | 166845 | 166846 | 166847 | 166848 | 166849 | 166850 | 166851 | 166852 | 166853 | 166854 | 166855 | 167193 | 167194 | 167211 | 167212 | 167213 | 167214 | 167215 | 167216