Bugzilla – Attachment 166846 Details for
Bug 34838
The ILL module and tests generate warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column
2311x-Bug-34838-Replace-SUPERAUTOLOAD-with-getcolu.patch (text/plain), 2.04 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-05-16 20:34:42 UTC
(
hide
)
Description:
[23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-05-16 20:34:42 UTC
Size:
2.04 KB
patch
obsolete
>From b30fee8ccb466800e7296289fc2fccb8085ec228 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 25 Sep 2023 15:07:37 +0000 >Subject: [PATCH] [23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column > >I'm not 100% happy with this but I'm out of ideas. > >I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. > >Test plan: > prove t/db_dependent/Koha/Illbackend.t > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Illrequest.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index 831d6fa52de..1496c45977c 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -298,7 +298,7 @@ correct category and records the fact that the status has changed > sub status_alias { > my ($self, $new_status_alias) = @_; > >- my $current_status_alias = $self->SUPER::status_alias; >+ my $current_status_alias = $self->get_column('status_alias'); > > if ($new_status_alias) { > # Keep a record of the previous status before we change it, >@@ -333,7 +333,7 @@ sub status_alias { > my $alias = Koha::AuthorisedValues->search( > { > category => 'ILL_STATUS_ALIAS', >- authorised_value => $self->SUPER::status_alias >+ authorised_value => $current_status_alias > }, > {}, > $self->branchcode >@@ -359,8 +359,8 @@ and sends a notice if appropriate > sub status { > my ( $self, $new_status) = @_; > >- my $current_status = $self->SUPER::status; >- my $current_status_alias = $self->SUPER::status_alias; >+ my $current_status = $self->get_column('status'); >+ my $current_status_alias = $self->get_column('status_alias'); > > if ($new_status) { > # Keep a record of the previous status before we change it, >-- >2.45.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34838
:
156178
|
156200
|
156201
|
156202
|
156204
|
156217
|
156218
|
156219
|
156220
|
166841
|
166842
|
166843
|
166844
|
166845
| 166846 |
166847
|
166848
|
166849
|
166850
|
166851
|
166852
|
166853
|
166854
|
166855
|
167193
|
167194
|
167211
|
167212
|
167213
|
167214
|
167215
|
167216