Bugzilla – Attachment 166853 Details for
Bug 34838
The ILL module and tests generate warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34838: Only check for status in status graph if request has a status
Bug-34838-Only-check-for-status-in-status-graph-if.patch (text/plain), 1.57 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-05-16 20:35:36 UTC
(
hide
)
Description:
Bug 34838: Only check for status in status graph if request has a status
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-05-16 20:35:36 UTC
Size:
1.57 KB
patch
obsolete
>From c39d11cad0f8d12439dbd519fc5e981edb12b4c2 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 26 Sep 2023 09:35:01 +0000 >Subject: [PATCH] Bug 34838: Only check for status in status graph if request > has a status > >This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ILL/Request.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index e0a9456dc39..e929105ed27 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -2073,12 +2073,12 @@ sub strings_map { > } > > my $status_string = >- ( exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{name} ) >+ ( $self->status && exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{name} ) > ? $status_graph_union->{ $self->status }->{name} > : $self->status; > > my $status_code = >- ( exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{id} ) >+ ( $self->status && exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{id} ) > ? $status_graph_union->{ $self->status }->{id} > : $self->status; > >-- >2.45.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34838
:
156178
|
156200
|
156201
|
156202
|
156204
|
156217
|
156218
|
156219
|
156220
|
166841
|
166842
|
166843
|
166844
|
166845
|
166846
|
166847
|
166848
|
166849
|
166850
|
166851
|
166852
|
166853
|
166854
|
166855
|
167193
|
167194
|
167211
|
167212
|
167213
|
167214
|
167215
|
167216