Bugzilla – Attachment 166881 Details for
Bug 36872
Untranslatable "Please make sure all selected titles have a pickup location set"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36872: Untranslatable strings in request.tt
Bug-36872-Untranslatable-strings-in-requesttt.patch (text/plain), 2.33 KB, created by
Marcel de Rooy
on 2024-05-17 09:53:17 UTC
(
hide
)
Description:
Bug 36872: Untranslatable strings in request.tt
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-05-17 09:53:17 UTC
Size:
2.33 KB
patch
obsolete
>From d926f123ac1ff55c03fa9ae07a3bcdf018bb071c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 16 May 2024 12:52:04 +0000 >Subject: [PATCH] Bug 36872: Untranslatable strings in request.tt >Content-Type: text/plain; charset=utf-8 > >There are errors in the JavaScript in the holds template in the staff >client which results in strings not being translatable. This patch >corrects the errors. > >To test, apply the patch and run through the process of placing a hold >on multiple items in the staff interface. > >- At the hold confirmation step, try to submit the form without > selecting pickup locations for one or more titles. >- You should get an alert, "Please make sure all selected titles have a > pickup location set". >- Uncheck the checkboxes next to each title you're placing a hold on. >- Submit the form. You should get an error: "Please select at least one > title". > >- Test the translation process with a language, e.g. fr-FR: >- In KTD, run: gulp po:update --lang fr-FR >- Check fr-FR-staff-prog.po for the line referring to > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1499 >- You should see the string "Please make sure all selected titles have a > pickup location set". > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index c3700c57de..5e7ab30a8e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1754,12 +1754,12 @@ > } > }); > if ( pickup_not_set > 0 ) { >- alert( _("Please make sure all selected titles have a pickup location set" + "\n") ); >+ alert( _("Please make sure all selected titles have a pickup location set") + "\n" ); > return false; > } > } > else { >- alert( _("Please select at least one title" + "\n") ); >+ alert( _("Please select at least one title") + "\n" ); > return false; > } > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36872
:
166826
|
166827
| 166881