Bugzilla – Attachment 166916 Details for
Bug 36897
Make it possible to use select[multiple] and select[size] in a sidebar
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar
Bug-36897-Make-it-possible-to-use-selectmultiple-a.patch (text/plain), 1.82 KB, created by
Phil Ringnalda
on 2024-05-17 20:29:33 UTC
(
hide
)
Description:
Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar
Filename:
MIME Type:
Creator:
Phil Ringnalda
Created:
2024-05-17 20:29:33 UTC
Size:
1.82 KB
patch
obsolete
>From 9973e734f7d3d5cb75b0d5ae3d0e3d028b38271c Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Fri, 17 May 2024 13:14:15 -0700 >Subject: [PATCH] Bug 36897: Make it possible to use select[multiple] and > select[size] in a sidebar > >Currently, if you put either <select multiple> or <select size="10"> in an ><aside><fieldset> sidebar, you get a height of "one fat line" rather than the >bigger box you would expect. > >Test plan: > 1. Without the patch, load Reports - Use saved > 2. Open Firefox developer tools to the Inspector tab > 3. With the "Pick an element from the page" tool, click on the word "Filter" > in the Reports page's sidebar > 4. Just above that line in the HTML display is a <fieldset class="brief"> - > right click that and choose Edit As HTML > 5. After the fieldset element, paste > ><select multiple><option>one</option><option>two</option></select><select size="10"></select> > > 6. Click outside the editor to save your changes > 7. Note that both new selects are only one line high > 8. Apply patch, run yarn build, Shift+reload to clear your cache > 9. Repeat steps 3 through 6 >10. Note that both selects are more than one line high >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index a0ba90ad5d..d9a23bab33 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -240,6 +240,11 @@ aside { > height: calc( 1.5em + .75rem + 2px ); > } > >+ select[multiple], >+ select[size] { >+ height: auto; >+ } >+ > label { > color: #696969; > display: block; >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36897
:
166916
|
166937
|
172375
|
172376