Bugzilla – Attachment 166934 Details for
Bug 36020
Port default recall notices to Template Toolkit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax:
Bug-36020-Port-default-recall-notices-to-Template-.patch (text/plain), 4.80 KB, created by
Martin Renvoize (ashimema)
on 2024-05-20 09:40:35 UTC
(
hide
)
Description:
Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax:
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-05-20 09:40:35 UTC
Size:
4.80 KB
patch
obsolete
>From fc977e8e8f9754faefd522928d3e62b015755235 Mon Sep 17 00:00:00 2001 >From: Lisette Scheer <lisette@bywatersolutions.com> >Date: Wed, 15 May 2024 14:37:30 +0000 >Subject: [PATCH] Bug 36020: Port default recall notices to Template Toolkit > The following notices relating to recalls all need to be updated to use > Template Toolkit syntax: > >RETURN_RECALLED_ITEM >PICKUP_RECALLED_ITEM >RECALL_REQUESTER_DET > >To test: >1) Observe the default notice contains <<>> tags >2) Apply the patch >3) reset_all >4) Check that the notice is now all in template toolkit [% %] tags >5) Enable recalls >6) Check an item out to a patron >7) Make sure the patron has a primary email >8) Make sure a secondary patron has a primary email >9) Generate a recall on the checked out item for the second patron >10) Check the first patron's notices tab to confirm the return recalled item notice generated properly. >11) Check the item back in and generate the recall slip and confirm it generated correctly. >12) Check the second patron's notices tab to confirm the pickup recalled item notice generated properly. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../mysql/en/mandatory/sample_notices.yml | 34 +++++++++---------- > 1 file changed, 17 insertions(+), 17 deletions(-) > >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index 7e411b92279..d95f9e380de 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -2257,11 +2257,11 @@ tables: > message_transport_type: email > lang: default > content: >- - "Date: <<today>>" >+ - "Date: [% today | $KohaDates %]" > - "" >- - "<<borrowers.firstname>> <<borrowers.surname>>," >+ - "[% borrower.firstname %] [% borrower.surname %]," > - "" >- - "A recall has been placed on the following item: <<biblio.title>> / <<biblio.author>> (<<items.barcode>>). The due date has been updated, and is now <<issues.date_due>>. Please return the item before the due date." >+ - "A recall has been placed on the following item: [% biblio.title %] / [% biblio.author %] ([% item.barcode %]). The due date has been updated, and is now [% issue.date_due %]. Please return the item before the due date." > - "" > - "Thank you!" > >@@ -2274,11 +2274,11 @@ tables: > message_transport_type: email > lang: default > content: >- - "Date: <<today>>" >+ - "Date: [% today | $KohaDates %]" > - "" >- - "<<borrowers.firstname>> <<borrowers.surname>>," >+ - "[% borrower.firstname %] [% borrower.surname %]," > - "" >- - "A recall that you requested on the following item: <<biblio.title>> / <<biblio.author>> (<<items.barcode>>) is now ready for you to pick up at <<recalls.pickup_library_id>>. Please pick up your item by <<recalls.expiration_date>>." >+ - "A recall that you requested on the following item: [% biblio.title %] / [% biblio.author %] ([% item.barcode %]) is now ready for you to pick up at [% recall.pickup_library_id %]. Please pick up your item by [% recalls.expiration_date %]." > - "" > - "Thank you!" > >@@ -2291,20 +2291,20 @@ tables: > message_transport_type: print > lang: default > content: >- - "Date: <<today>>" >+ - "Date: [% today | $KohaDates %]" > - "" >- - "Recall for pickup at <<branches.branchname>>" >- - "<<borrowers.surname>>, <<borrowers.firstname>> (<<borrowers.cardnumber>>)" >- - "<<borrowers.phone>>" >- - "<<borrowers.streetnumber>> <<borrowers.address>>, <<borrowers.address2>>, <<borrowers.city>> <<borrowers.zipcode>>" >- - "<<borrowers.email>>" >+ - "Recall for pickup at [% branche.branchname %]" >+ - "[% borrower.surname %], [% borrower.firstname %] ([% borrower.cardnumber %])" >+ - "[% borrower.phone %]" >+ - "[% borrower.streetnumber %] [% borrower.address %], [% borrower.address2 %], [% borrower.city %] [% borrower.zipcode %]" >+ - "[% borrowes.email %]" > - "" > - "ITEM RECALLED" >- - "<<biblio.title>> by <<biblio.author>>" >- - "Barcode: <<items.barcode>>" >- - "Callnumber: <<items.itemcallnumber>>" >- - "Waiting since: <<recalls.waiting_date>>" >- - "Notes: <<recalls.notes>>" >+ - "[% biblio.title %] by [% biblio.author %]" >+ - "Barcode: [% item.barcode %]" >+ - "Callnumber: [% item.itemcallnumber %]" >+ - "Waiting since: [% recall.waiting_date %]" >+ - "Notes: [% recall.notes %]" > > - module: members > code: 2FA_DISABLE >-- >2.45.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36020
:
166784
| 166934 |
166935
|
170885
|
170886
|
170887
|
170889
|
172134
|
172135
|
172147
|
172148
|
176478
|
176479