Bugzilla – Attachment 166946 Details for
Bug 36899
Further improvements to holds request page, part 2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36899: Account for item groups
Bug-36899-Account-for-item-groups.patch (text/plain), 4.04 KB, created by
Lucas Gass (lukeg)
on 2024-05-20 22:06:15 UTC
(
hide
)
Description:
Bug 36899: Account for item groups
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-05-20 22:06:15 UTC
Size:
4.04 KB
patch
obsolete
>From bcf1fb579f7b0240c579f6eb4d6225b0879324bd Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 20 May 2024 22:05:43 +0000 >Subject: [PATCH] Bug 36899: Account for item groups > >--- > .../prog/en/modules/reserve/request.tt | 33 ++++++++++--------- > 1 file changed, 17 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index c3eabb5ee3..90041a201a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -693,21 +693,19 @@ > [% biblio_info = biblioloop.0 %] > <!-- ItemGroup level holds --> > [% IF Koha.Preference('EnableItemGroupHolds') && biblio_info.object.item_groups.count %] >- <fieldset class="rows"> >+ <fieldset class="rows any_specific"> > <legend> >- <button type="button"> >- [% IF force_hold_level == 'item_group' %] >- <input type="radio" class="requestgrp" id="requestgrp" name="request" checked="checked" disabled="true" /> >- <span class="error"><i>(Required)</i></span> >- [% ELSIF force_hold_level == 'item' || force_hold_level == 'record' %] >- <input type="radio" class="requestgrp" id="requestgrp" name="request" disabled="true" /> >- [% ELSE %] >- <input type="radio" class="requestgrp" id="requestgrp" name="request" /> >- [% END %] >- <label for="requestgrp" class="inline"> >- Hold next available item from an item group >- </label> >- </button> >+ [% IF force_hold_level == 'item_group' %] >+ <input type="radio" class="requestgrp" id="requestgrp" name="request" checked="checked" disabled="true" /> >+ <span class="error"><i>(Required)</i></span> >+ [% ELSIF force_hold_level == 'item' || force_hold_level == 'record' %] >+ <input type="radio" class="requestgrp" id="requestgrp" name="request" disabled="true" /> >+ [% ELSE %] >+ <input type="radio" class="requestgrp" id="requestgrp" name="request" /> >+ [% END %] >+ <label for="requestgrp" class="inline"> >+ Hold next available item from an item group >+ </label> > </legend> > > <fieldset class="enable_request_group disable_request_any disable_request_specific"> >@@ -1693,14 +1691,17 @@ > const fieldset = $(this).find('fieldset:first'); > > if ( fieldset.hasClass('disabled') ) { >- $('.enable_request_specific, .enable_request_any').removeClass('enabled'); >+ $('.enable_request_specific, .enable_request_any, .enable_request_group').removeClass('enabled'); > const specific_cb = $(this).find('#requestspecificitem'); > const any_cb = $(this).find('#requestany'); >+ const itemgroup_cb = $(this).find('#requestgrp'); > > if ( specific_cb.length ) { > specific_cb.prop('checked', true); >- } else { >+ } else if ( any_cb.length ) { > any_cb.prop('checked', true); >+ } else { >+ itemgroup_cb.prop('checked', true); > } > > fieldset.removeClass('disabled').addClass('enabled'); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36899
:
166938
|
166939
|
166944
|
166945
|
166946
|
166971
|
166972
|
166973