Bugzilla – Attachment 166956 Details for
Bug 31330
Branchcode used for routing preview can be wrong
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31330: Don't pass serial_escaped
Bug-31330-Dont-pass-serialescaped.patch (text/plain), 2.77 KB, created by
Jonathan Druart
on 2024-05-21 09:44:46 UTC
(
hide
)
Description:
Bug 31330: Don't pass serial_escaped
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-05-21 09:44:46 UTC
Size:
2.77 KB
patch
obsolete
>From fd105bb399f5c6dc33c02b8aa3d102452ed320a4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 May 2024 11:33:46 +0200 >Subject: [PATCH] Bug 31330: Don't pass serial_escaped > >What's the point of this? Am I missing something here? >--- > .../prog/en/modules/serials/subscription-detail.tt | 4 ++-- > serials/routing-preview.pl | 2 +- > serials/subscription-detail.pl | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index 27aab7ad8da..8bc2e91fa20 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -489,8 +489,8 @@ > }); > $("#show_all_orders").click(); > >- [% IF print_routing_list_issue %] >- var myurl = '/cgi-bin/koha/serials/routing-preview.pl?op=print&subscriptionid=[% subscriptionid | uri %]&issue=[% print_routing_list_issue | uri %]'; >+ [% IF print_routing_list_serialid %] >+ var myurl = '/cgi-bin/koha/serials/routing-preview.pl?op=print&subscriptionid=[% subscriptionid | uri %]&serialid=[% print_routing_list_serialid | uri %]'; > window.open(myurl,'PrintSlip','width=500,height=500,toolbar=no,scrollbars=yes'); > [% END %] > >diff --git a/serials/routing-preview.pl b/serials/routing-preview.pl >index 0c5ed4907e3..fc85ac2fc04 100755 >--- a/serials/routing-preview.pl >+++ b/serials/routing-preview.pl >@@ -100,7 +100,7 @@ if($op eq 'cud-save_and_preview'){ > } > } > } >- print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid&print_routing_list_issue=" . $query->param('issue_escaped')); >+ print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid&print_routing_list_serialid=" . $serialid); > exit; > } elsif ( $op eq 'print' ) { > ( $template, $loggedinuser, $cookie ) = get_template_and_user( >diff --git a/serials/subscription-detail.pl b/serials/subscription-detail.pl >index d033ab30d84..e7ea7d17793 100755 >--- a/serials/subscription-detail.pl >+++ b/serials/subscription-detail.pl >@@ -166,7 +166,7 @@ $template->param( > orders_grouped => $orders_grouped, > (uc(C4::Context->preference("marcflavour"))) => 1, > mana_comments => $subs->{comments}, >- print_routing_list_issue => scalar $query->param('print_routing_list_issue'), >+ print_routing_list_serialid => scalar $query->param('print_routing_list_serialid'), > ); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31330
:
138912
|
166955
| 166956