Attachment 166971 Details for Bug 36899 – Bug 36899: Make entire fieldset clickable

[patch] Bug 36899: Make entire fieldset clickable

Bug-36899-Make-entire-fieldset-clickable.patch (text/plain), 3.46 KB, created by Martin Renvoize (ashimema) on 2024-05-21 13:14:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-21 13:14:54 UTC

Size: 3.46 KB

patch

obsolete

>From 7f3775d2d8c5eb18668d4e68e35503e7215b78a9 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 20 May 2024 15:55:11 +0000
>Subject: [PATCH] Bug 36899: Make entire fieldset clickable
>
>To test:
>1. APPLY PATCH
>2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
>3. Follow the test plan from bug 36864
>4. Now the entire disabled fieldset should be clickable.
>5. When the disabled fieldset is clicked from anywhere with it the fieldset should become enabled. The other one should then be disabled.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/css/src/staff-global.scss            |  3 +++
> .../prog/en/modules/reserve/request.tt        | 23 +++++++++++++++++--
> 2 files changed, 24 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index a0ba90ad5de..f63558b8fbe 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -4802,6 +4802,9 @@ div .suggestion_note {
> }
> 
> #circ_request {
>+    fieldset:has(fieldset.disabled) {
>+        cursor: pointer;
>+    }
>     fieldset {
>         position: relative;
>         &.disabled {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 5e7ab30a8ee..6588dc01016 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -611,7 +611,7 @@
>                                 </li>
>                             </ol>
>                             </fieldset>
>-                            <fieldset class="rows">
>+                            <fieldset class="rows any_specific">
>                                 <legend>
>                                     [% IF force_hold_level == 'item' || force_hold_level == 'item_group' %]
>                                         <input type="radio" id="requestany" name="request" disabled="true" />
>@@ -792,7 +792,7 @@
>                         [% END %]
>                         
> 
>-                        <fieldset class="rows">
>+                        <fieldset class="rows any_specific">
>                             <legend>
>                                 [% IF force_hold_level == 'item' %]
>                                      <input type="radio" id="requestspecificitem" name="request" class="requestspecific" checked="checked" disabled='disabled'/>
>@@ -1691,6 +1691,25 @@
>             }
>         }
> 
>+        $('.any_specific').click(function() {
>+            const fieldset = $(this).find('fieldset:first');
>+            $('.enable_request_specific, .enable_request_any').removeClass('enabled');
>+
>+            if ( fieldset.hasClass('disabled') ) {
>+                const specific_cb = $(this).find('#requestspecificitem');
>+                const any_cb = $(this).find('#requestany');
>+
>+                if ( specific_cb.length ) {
>+                    specific_cb.prop('checked', true);
>+                } else {
>+                    any_cb.prop('checked', true);
>+                }
>+
>+                fieldset.removeClass('disabled').addClass('enabled');
>+                ToggleHoldsToPlace();
>+            }
>+        });
>+
>         function check( e, table ) {
> 
>             var msg = "";
>-- 
>2.45.1

Actions: View | Diff | Splinter Review

Attachments on bug 36899: 166938 | 166939 | 166944 | 166945 | 166946 | 166971 | 166972 | 166973