Bugzilla – Attachment 167004 Details for
Bug 36858
Crash on wrong page number in opac-shelves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36858: Remove warnings
Bug-36858-Remove-warnings.patch (text/plain), 1.67 KB, created by
Jonathan Druart
on 2024-05-22 07:29:28 UTC
(
hide
)
Description:
Bug 36858: Remove warnings
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-05-22 07:29:28 UTC
Size:
1.67 KB
patch
obsolete
>From 5ca7e8518ccdca7228f826783be76ce53cdaf4f9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 22 May 2024 09:24:06 +0200 >Subject: [PATCH] Bug 36858: Remove warnings > >Argument "" isn't numeric in int > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > opac/opac-shelves.pl | 4 ++-- > virtualshelves/shelves.pl | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl >index 2b0d245adc6..cf1a5184e51 100755 >--- a/opac/opac-shelves.pl >+++ b/opac/opac-shelves.pl >@@ -86,8 +86,8 @@ if (C4::Context->preference("BakerTaylorEnabled")) { > ); > } > >-my $referer = $query->param('referer') || $op; >-my $page = int( $query->param('page') // q{} ) || 1; >+my $referer = $query->param('referer') || $op; >+my $page = int( $query->param('page') || 1 ); > my $public = 0; > $public = 1 if $query->param('public') && $query->param('public') == 1; > >diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl >index 61a416632d1..90b5c93fa94 100755 >--- a/virtualshelves/shelves.pl >+++ b/virtualshelves/shelves.pl >@@ -54,9 +54,9 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > >-my $op = $query->param('op') || 'list'; >-my $referer = $query->param('referer') || $op; >-my $page = int( $query->param('page') // q{} ) || 1; >+my $op = $query->param('op') || 'list'; >+my $referer = $query->param('referer') || $op; >+my $page = int( $query->param('page') || 1 ); > my $public = $query->param('public') ? 1 : 0; > my ( $shelf, $shelfnumber, @messages, $allow_transfer ); > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36858
:
166978
|
167002
|
167003
| 167004