Bugzilla – Attachment 167020 Details for
Bug 26176
AutoLocation is badly named
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26176: (follow-up) Prevent random failures from too long branchcode
Bug-26176-follow-up-Prevent-random-failures-from-t.patch (text/plain), 1.65 KB, created by
Nick Clemens (kidclamp)
on 2024-05-22 11:06:29 UTC
(
hide
)
Description:
Bug 26176: (follow-up) Prevent random failures from too long branchcode
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-05-22 11:06:29 UTC
Size:
1.65 KB
patch
obsolete
>From a2acbcee8477ee752ccd17a8c4b6da2d98676db6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 21 May 2024 13:56:17 +0000 >Subject: [PATCH] Bug 26176: (follow-up) Prevent random failures from too long > branchcode > >--- > t/db_dependent/Auth.t | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t >index 633375d4718..5f50c365853 100755 >--- a/t/db_dependent/Auth.t >+++ b/t/db_dependent/Auth.t >@@ -1342,7 +1342,11 @@ subtest 'StaffLoginBranchBasedOnIP' => sub { > > t::lib::Mocks::mock_preference( 'StaffLoginRestrictBranchByIP', 0 ); > my $other_branch = $builder->build_object( >- { class => 'Koha::Libraries', value => { branchip => "127.0.0.1", branchcode => "z" . $branch->branchcode } } ); >+ { >+ class => 'Koha::Libraries', >+ value => { branchip => "127.0.0.1", branchcode => substr( "z" . $branch->branchcode, 0, 10 ) } >+ } >+ ); > ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 0, { catalogue => 1 }, 'intranet' ); > is( $userid, $patron->userid, "User successfully logged in" ); > $session = C4::Auth::get_session($sessionID); >@@ -1434,7 +1438,7 @@ subtest 'StaffLoginRestrictBranchByIP' => sub { > my $another_library = $builder->build_object( > { > class => 'Koha::Libraries', >- value => { branchip => '129.0.0.1', branchcode => "z" . $other_library->branchcode } >+ value => { branchip => "129.0.0.1", branchcode => substr( "z" . $other_library->branchcode, 0, 10 ) } > } > ); > ( $userid, $cookie, $sessionID, $flags, $template ) = >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26176
:
166975
|
166976
|
167019
|
167020
|
167072
|
167091
|
167092
|
167093
|
167094
|
167095
|
167096
|
167114
|
167162