Attachment 167043 Details for Bug 36816 – Bug 36816: Remove warning

[patch] Bug 36816: Remove warning

Bug-36816-Remove-warning.patch (text/plain), 1.45 KB, created by Pedro Amorim on 2024-05-22 14:03:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-05-22 14:03:00 UTC

Size: 1.45 KB

patch

obsolete

>From 588dec42666a85496d5300ae245fbd0055509aad Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 22 May 2024 10:08:30 +0200
>Subject: [PATCH] Bug 36816: Remove warning
>
>Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629.
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> opac/opac-memberentry.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
>index cc350990d2..7adc381d47 100755
>--- a/opac/opac-memberentry.pl
>+++ b/opac/opac-memberentry.pl
>@@ -615,11 +615,11 @@ sub FilterUnchangedAttributes {
> 
>     # Loop through the current patron attributes
>     foreach my $attribute_type ( keys %{ $patron_attribute_types } ) {
>-        if ( $patron_attribute_types->{ $attribute_type } !=  $passed_attribute_types->{ $attribute_type } ) {
>+        if ( ( $patron_attribute_types->{$attribute_type} // q{} ) ne ( $passed_attribute_types->{$attribute_type} // q{} ) ) {
>             # count differs, overwrite all attributes for given type
>-            foreach my $attr (@{ $entered_attributes }) {
>+            foreach my $attr ( @{$entered_attributes} ) {
>                 push @changed_attributes, $attr
>-                    if $attr->{ code } eq $attribute_type;
>+                    if $attr->{code} eq $attribute_type;
>             }
>         } else {
>             # count matches, check values
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36816: 167008 | 167009 | 167042 | 167043 | 167159 | 167160