Attachment 167055 Details for Bug 36916 – Bug 36916: Do not generate invalid JS or CSS from TestBuilder

[patch] Bug 36916: Do not generate invalid JS or CSS from TestBuilder

Bug-36916-Do-not-generate-invalid-JS-or-CSS-from-T.patch (text/plain), 1.69 KB, created by David Nind on 2024-05-23 04:04:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-05-23 04:04:18 UTC

Size: 1.69 KB

patch

obsolete

>From 2f10423102b706e0dc5b0c7e7f2a4ad5d58e6834 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 22 May 2024 10:31:29 +0200
>Subject: [PATCH] Bug 36916: Do not generate invalid JS or CSS from TestBuilder
>
>TestBuilder generates random strings for branches.opacuserjs and branches.opacusercss which produces invalid JS and CSS.
>
>Selenium has several warnings related to this:
>
>koha-selenium-1   | JavaScript error: http://koha:8080/cgi-bin/koha/opac-user.pl, line 1744: ReferenceError: CLYxPjQ152 is not defined
>koha-selenium-1   | JavaScript error: http://koha:8080/cgi-bin/koha/opac-search.pl, line 2069: ReferenceError: CLYxPjQ152 is not defined
>koha-selenium-1   | JavaScript error: http://koha:8080/cgi-bin/koha/opac-reserve.pl, line 1351: ReferenceError: CLYxPjQ152 is not defined
>
>Because of the following in the DOM
>    <script>
>        CLYxPjQ152
>    </script>
>
>This patch suggests to set to an empty string by default, to prevent random failure or inconsistent behaviours when testing the UI.
>
>Test plan:
>Run t/db_dependent/selenium/authentication.t and watch the selenium
>output.
>With this patch applied you will not see the "JavaScript error" lines
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/lib/TestBuilder.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
>index 630fab0cfb..57506b11d7 100644
>--- a/t/lib/TestBuilder.pm
>+++ b/t/lib/TestBuilder.pm
>@@ -624,6 +624,8 @@ sub _gen_default_values {
>         },
>         Branch => {
>             pickup_location => 0,
>+            opacuserjs      => q{},
>+            opacusercss     => q{},
>         },
>         Reserve => {
>             non_priority  => 0,
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36916: 167011 | 167055 | 167161